From: Mark Brown <broonie@kernel.org>
To: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
Cc: lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
bjorn.andersson@linaro.org, vinod.koul@linaro.org,
niklas.cassel@linaro.org, khasim.mohammed@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/3] drivers: regulator: qcom: add PMS405 SPMI regulator
Date: Thu, 23 May 2019 14:16:41 +0100 [thread overview]
Message-ID: <20190523131641.GD17245@sirena.org.uk> (raw)
In-Reply-To: <a89763cb-5d50-0927-7912-6ccf38ae1d66@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
On Thu, May 23, 2019 at 10:35:46AM +0200, Jorge Ramirez wrote:
> Would you accept if I wrote a separate driver specific to pms405 or do
> you want me to integrate in qcom-spmi_regulator.c?
> I am asking because none of the ops will use the common functions (I
> wont be reusing much code from this qcom-spmi_regulator.c file)
I don't really mind, if there's nothing really shared then making it a
separate driver is probably best but it's not a strong opinion either
way.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-23 13:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 11:45 [PATCH 0/3] qcom: add PMS405 SPMI regulator Jorge Ramirez-Ortiz
2019-01-28 11:45 ` [PATCH 1/3] dt-bindings: qcom_spmi: Document pms405 support Jorge Ramirez-Ortiz
2019-02-23 0:44 ` Rob Herring
2019-01-28 11:45 ` [PATCH 2/3] drivers: regulator: qcom: add PMS405 SPMI regulator Jorge Ramirez-Ortiz
2019-02-04 9:03 ` Mark Brown
2019-04-19 17:29 ` Jorge Ramirez
2019-04-25 18:37 ` Mark Brown
2019-04-25 19:44 ` Jorge Ramirez
2019-04-27 18:21 ` Mark Brown
2019-04-29 12:31 ` Jorge Ramirez
2019-05-02 2:33 ` Mark Brown
2019-05-02 11:30 ` Jorge Ramirez
2019-05-03 6:26 ` Mark Brown
2019-05-03 8:29 ` Jorge Ramirez
2019-05-06 4:38 ` Mark Brown
2019-05-23 8:35 ` Jorge Ramirez
2019-05-23 13:16 ` Mark Brown [this message]
2019-01-28 11:45 ` [PATCH 3/3] arm64: dts: qcom: pms405: add spmi regulators Jorge Ramirez-Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523131641.GD17245@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=khasim.mohammed@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=niklas.cassel@linaro.org \
--cc=robh+dt@kernel.org \
--cc=vinod.koul@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox