Re: [PATCH 4.14 00/77] 4.14.122-stable review

Greg Kroah-Hartman
2019-05-24T05:53:21Z

On Fri, May 24, 2019 at 09:28:05AM +0900, Nobuhiro Iwamatsu wrote:
> Hi.
>
> 2019年5月24日(金) 4:11 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> >
> > This is the start of the stable review cycle for the 4.14.122 release.
> > There are 77 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sat 25 May 2019 06:15:09 PM UTC.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.122-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> >
> > -------------
> > Pseudo-Shortlog of commits:
> >
> > Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Linux 4.14.122-rc1
> >
>
> <snip>
>
> >
> > Yifeng Li <tomli@tomli.me>
> > fbdev: sm712fb: fix crashes and garbled display during DPMS modesetting
> >
>
> There is a problem in this commit, which is fixed in the following commit:
> 9dc20113988b9a75ea6b3abd68dc45e2d73ccdab
>
> commit 9dc20113988b9a75ea6b3abd68dc45e2d73ccdab
> Author: Yifeng Li <tomli@tomli.me>
> Date: Tue Apr 2 17:14:10 2019 +0200
>
> fbdev: sm712fb: fix memory frequency by avoiding a switch/case fallthrough
>
> A fallthrough in switch/case was introduced in f627caf55b8e ("fbdev:
> sm712fb: fix crashes and garbled display during DPMS modesetting"),
> due to my copy-paste error, which would cause the memory clock frequency
> for SM720 to be programmed to SM712.
>
> Since it only reprograms the clock to a different frequency, it's only
> a benign issue without visible side-effect, so it also evaded Sudip
> Mukherjee's code review and regression tests. scripts/checkpatch.pl
> also failed to discover the issue, possibly due to nested switch
> statements.
>
> This issue was found by Stephen Rothwell by building linux-next with
> -Wimplicit-fallthrough.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: f627caf55b8e ("fbdev: sm712fb: fix crashes and garbled
> display during DPMS modesetting")
> Signed-off-by: Yifeng Li <tomli@tomli.me>
> Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>
> And this is also necessary for other stable-rc tree.
> Please apply this commit to 4.9.y, 4.14.y, 4.19.y, 5.0.y and 5.1.y.

Now queued up everywhere, thanks!

greg k-h