From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBE1DC072B5 for ; Fri, 24 May 2019 08:06:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6E252184B for ; Fri, 24 May 2019 08:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558685166; bh=vgZcDHT3SM5hC1ueqbfS3ee1j3qnp9qGc2/YoL1k5FE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=AcR98BEoTQSY3aIr5aezwQG/0dTJser0uDp7I2M/lV+JrkYix1qv34tpJM0cH4htB fjmuqPeTfwT5f8az6WxiIbnpjzFyUS8o0Y7vTKoR2rjxGpgOg7c49aRyFRN0NbLhEu kpfL2Lv1wqnApUuVfCPW27QN2GorrHIzQ9PEDFWo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389330AbfEXIGF (ORCPT ); Fri, 24 May 2019 04:06:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:45156 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389046AbfEXIGF (ORCPT ); Fri, 24 May 2019 04:06:05 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B0702133D; Fri, 24 May 2019 08:06:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558685164; bh=vgZcDHT3SM5hC1ueqbfS3ee1j3qnp9qGc2/YoL1k5FE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gAJmLl2IDvA9SaE+pSxROqx56O5HVK4fHHBwrqvuU1e2oKD1TSeooAr9d7RnKN062 y39ij4q1bxJel/nQjAQ/6vlsndYcBFQZKaIe39q4YWbJnrLukxXvKBAiBA2p78VckA C2CiYPMn8RCkhf5IOEVHTGbzulH/mdiDB/SAW/t8= Date: Fri, 24 May 2019 10:06:02 +0200 From: Greg Kroah-Hartman To: Grzegorz Halat Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Jiri Slaby , Oleksandr Natalenko Subject: Re: [PATCH] vt/fbcon: deinitialize resources in visual_init() after failed memory allocation Message-ID: <20190524080602.GA19514@kroah.com> References: <20190426145946.26537-1-ghalat@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 16, 2019 at 04:33:40PM +0200, Grzegorz Halat wrote: > On Fri, 26 Apr 2019 at 16:59, Grzegorz Halat wrote: > > > > After memory allocation failure vc_allocate() doesn't clean up data > > which has been initialized in visual_init(). In case of fbcon this > > leads to divide-by-0 in fbcon_init() on next open of the same tty. > > Hi, > A gentle reminder. Could you please review my patch? I've seen two > crashes caused by this bug. How? How are you triggering a memory allocation failure in a "normal" system? Anyway, I'll queue this up, but it really does not seem like anything anyone would see "in the wild". thanks, greg k-h