From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2861C072B5 for ; Fri, 24 May 2019 14:10:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FDC420879 for ; Fri, 24 May 2019 14:10:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403949AbfEXOKg (ORCPT ); Fri, 24 May 2019 10:10:36 -0400 Received: from verein.lst.de ([213.95.11.211]:54179 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403843AbfEXOKg (ORCPT ); Fri, 24 May 2019 10:10:36 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id D03B7227A81; Fri, 24 May 2019 16:10:11 +0200 (CEST) Date: Fri, 24 May 2019 16:10:11 +0200 From: "hch@lst.de" To: Thomas Hellstrom Cc: "hch@lst.de" , "cai@lca.pw" , "daniel@ffwll.ch" , "robin.murphy@arm.com" , "m.szyprowski@samsung.com" , "dri-devel@lists.freedesktop.org" , Linux-graphics-maintainer , "airlied@linux.ie" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] drm/vmwgfx: fix a warning due to missing dma_parms Message-ID: <20190524141011.GA23514@lst.de> References: <20190524023719.1495-1-cai@lca.pw> <20190524061936.GA2337@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 24, 2019 at 11:57:04AM +0000, Thomas Hellstrom wrote: > It's a PCI device. The struct device * used in dma_map_sg() is the same > as the &pci_dev->dev handed to the probe() callback. But at probe time, > the struct device::dma_parms is non-NULL, at least on my system so > there shouldn't really be a need to kzalloc() it. Then there is something really odd going on in the OPs setup..