[PATCH] [trivial] perf: Spelling s/EACCESS/EACCES/

[PATCH] [trivial] perf: Spelling s/EACCESS/EACCES/

[Geert Uytterhoeven]

The correct spelling is EACCES:

include/uapi/asm-generic/errno-base.h:#define EACCES 13 /* Permission denied */

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 include/linux/perf_event.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 0ab99c7b652d41b1..10569e25b5a9b656 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -289,7 +289,7 @@ struct pmu {
 	 *  -EBUSY	-- @event is for this PMU but PMU temporarily unavailable
 	 *  -EINVAL	-- @event is for this PMU but @event is not valid
 	 *  -EOPNOTSUPP -- @event is for this PMU, @event is valid, but not supported
-	 *  -EACCESS	-- @event is for this PMU, @event is valid, but no privilidges
+	 *  -EACCES	-- @event is for this PMU, @event is valid, but no privilidges
 	 *
 	 *  0		-- @event is for this PMU and valid
 	 *
-- 
2.17.1

Re: [PATCH] [trivial] perf: Spelling s/EACCESS/EACCES/

[Ingo Molnar]

* Geert Uytterhoeven <geert+renesas@glider.be> wrote:

> The correct spelling is EACCES:
> 
> include/uapi/asm-generic/errno-base.h:#define EACCES 13 /* Permission denied */
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  include/linux/perf_event.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 0ab99c7b652d41b1..10569e25b5a9b656 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -289,7 +289,7 @@ struct pmu {
>  	 *  -EBUSY	-- @event is for this PMU but PMU temporarily unavailable
>  	 *  -EINVAL	-- @event is for this PMU but @event is not valid
>  	 *  -EOPNOTSUPP -- @event is for this PMU, @event is valid, but not supported
> -	 *  -EACCESS	-- @event is for this PMU, @event is valid, but no privilidges
> +	 *  -EACCES	-- @event is for this PMU, @event is valid, but no privilidges
>  	 *
>  	 *  0		-- @event is for this PMU and valid
>  	 *


Actually, -EACCES got typoed itself and survived due to historic reasons. 
I think we can tolerate the 'typo' fixed in documentation, can we?

Also, the *far* bigger typo is, in the same line:

s/privilidges
 /privileges

:-)

Thanks,

	Ingo

Re: [PATCH] [trivial] perf: Spelling s/EACCESS/EACCES/

[Geert Uytterhoeven]

Hi Ingo,

On Mon, May 27, 2019 at 4:12 PM Ingo Molnar <mingo@kernel.org> wrote:
> * Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> > The correct spelling is EACCES:
> >
> > include/uapi/asm-generic/errno-base.h:#define EACCES 13 /* Permission denied */
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

> > --- a/include/linux/perf_event.h
> > +++ b/include/linux/perf_event.h
> > @@ -289,7 +289,7 @@ struct pmu {
> >        *  -EBUSY      -- @event is for this PMU but PMU temporarily unavailable
> >        *  -EINVAL     -- @event is for this PMU but @event is not valid
> >        *  -EOPNOTSUPP -- @event is for this PMU, @event is valid, but not supported
> > -      *  -EACCESS    -- @event is for this PMU, @event is valid, but no privilidges
> > +      *  -EACCES     -- @event is for this PMU, @event is valid, but no privilidges
> >        *
> >        *  0           -- @event is for this PMU and valid
> >        *
>
>
> Actually, -EACCES got typoed itself and survived due to historic reasons.

Quite possible... Someone pointed out a while ago it is part of POSIX,
hence it cannot be changed.

Probably we can do "#define EACCESS EACCES"?

> I think we can tolerate the 'typo' fixed in documentation, can we?

IMHO we cannot, as e.g. "git grep -w" won't match both.
Do you really want the documentation to differ from the implementation?

> Also, the *far* bigger typo is, in the same line:
>
> s/privilidges
>  /privileges

Thanks, that one didn't show up with "git grep -w EACCESS" ;-)
Will send v2...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] [trivial] perf: Spelling s/EACCESS/EACCES/

[Ingo Molnar]

* Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> Hi Ingo,
> 
> On Mon, May 27, 2019 at 4:12 PM Ingo Molnar <mingo@kernel.org> wrote:
> > * Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> > > The correct spelling is EACCES:
> > >
> > > include/uapi/asm-generic/errno-base.h:#define EACCES 13 /* Permission denied */
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> > > --- a/include/linux/perf_event.h
> > > +++ b/include/linux/perf_event.h
> > > @@ -289,7 +289,7 @@ struct pmu {
> > >        *  -EBUSY      -- @event is for this PMU but PMU temporarily unavailable
> > >        *  -EINVAL     -- @event is for this PMU but @event is not valid
> > >        *  -EOPNOTSUPP -- @event is for this PMU, @event is valid, but not supported
> > > -      *  -EACCESS    -- @event is for this PMU, @event is valid, but no privilidges
> > > +      *  -EACCES     -- @event is for this PMU, @event is valid, but no privilidges
> > >        *
> > >        *  0           -- @event is for this PMU and valid
> > >        *
> >
> >
> > Actually, -EACCES got typoed itself and survived due to historic reasons.
> 
> Quite possible... Someone pointed out a while ago it is part of POSIX,
> hence it cannot be changed.
> 
> Probably we can do "#define EACCESS EACCES"?

Don't think that's a good idea, nor is it necessary: it's only a comment, 
right? But yeah, I guess we can do.

> > I think we can tolerate the 'typo' fixed in documentation, can we?
> 
> IMHO we cannot, as e.g. "git grep -w" won't match both.
> Do you really want the documentation to differ from the implementation?
> 
> > Also, the *far* bigger typo is, in the same line:
> >
> > s/privilidges
> >  /privileges
> 
> Thanks, that one didn't show up with "git grep -w EACCESS" ;-)
> Will send v2...

:-)

Thanks,

	Ingo