From: Sam Ravnborg <sam@ravnborg.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Thierry Reding <thierry.reding@gmail.com>,
devicetree@vger.kernel.org, od@zcrc.me,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Extend drm_bus_flags? [Was: [PATCH v3 2/3] drm: Add bus flag for Sharp-specific signals]
Date: Mon, 27 May 2019 22:29:32 +0200 [thread overview]
Message-ID: <20190527202932.GA28319@ravnborg.org> (raw)
In-Reply-To: <20190425231854.24479-2-paul@crapouillou.net>
Hi all.
Please see mail below - is it OK to extend drm_bus_flags to
represent "SHARP signals"?
Paul (and I) could not find any better way to let the panel tell the
display driver that it requires the special SHARP signals.
This has been pending almost a month now and it would only be fair
to either accept the solution or to give Paul guidiance how to move
forward.
There is a display driver that awaits the resilutions of this issue.
Sam
On Fri, Apr 26, 2019 at 01:18:53AM +0200, Paul Cercueil wrote:
> Add the DRM_BUS_FLAG_SHARP_SIGNALS to the drm_bus_flags enum.
>
> This flags can be used when the display must be driven with the
> Sharp-specific signals SPL, CLS, REV, PS.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>
> Notes:
> v3: New patch
>
> include/drm/drm_connector.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index 02a131202add..ac7d58fd1e03 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -323,6 +323,8 @@ enum drm_panel_orientation {
> * edge of the pixel clock
> * @DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE: Sync signals are sampled on the falling
> * edge of the pixel clock
> + * @DRM_BUS_FLAG_SHARP_SIGNALS: Set if the Sharp-specific signals
> + * (SPL, CLS, PS, REV) must be used
> */
> enum drm_bus_flags {
> DRM_BUS_FLAG_DE_LOW = BIT(0),
> @@ -341,6 +343,7 @@ enum drm_bus_flags {
> DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE = DRM_BUS_FLAG_SYNC_NEGEDGE,
> DRM_BUS_FLAG_SYNC_SAMPLE_POSEDGE = DRM_BUS_FLAG_SYNC_NEGEDGE,
> DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE = DRM_BUS_FLAG_SYNC_POSEDGE,
> + DRM_BUS_FLAG_SHARP_SIGNALS = BIT(8),
> };
>
> /**
> --
> 2.21.0.593.g511ec345e18
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-05-27 20:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 23:18 [PATCH v3 1/3] dt-bindings: display: Add Sharp LS020B1DD01D panel documentation Paul Cercueil
2019-04-25 23:18 ` [PATCH v3 2/3] drm: Add bus flag for Sharp-specific signals Paul Cercueil
2019-04-27 6:32 ` Sam Ravnborg
2019-05-27 20:29 ` Sam Ravnborg [this message]
2019-04-25 23:18 ` [PATCH v3 3/3] drm/panel: simple: Add Sharp LS020B1DD01D panel support Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527202932.GA28319@ravnborg.org \
--to=sam@ravnborg.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox