From: Borislav Petkov <bp@alien8.de>
To: "Zhao, Yakui" <yakui.zhao@intel.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
Jason Chen CJ <jason.cj.chen@intel.com>
Subject: Re: [PATCH v6 4/4] x86/acrn: Add hypercall for ACRN guest
Date: Tue, 28 May 2019 00:46:18 +0200 [thread overview]
Message-ID: <20190527224618.GB8209@cz.tnic> (raw)
In-Reply-To: <b8210e0e-bdf2-3e17-ce9a-d7a3ca0e6672@intel.com>
On Mon, May 27, 2019 at 10:57:09AM +0800, Zhao, Yakui wrote:
> I refer to the Xen/KVM hypercall to add the ACRN hypercall in one separate
> header.
And?
> The ACRN hypercall is defined in one separate acrn_hypercall.h and can be
> included explicitly by the *.c that needs the hypercall.
Sure but what else will need the hypercall definition except stuff which
already needs acrn.h? I.e., why is the separate header needed?
> The hypercall will be used in driver part. Before the driver part is added,
> it seems that the defined ACRN hypercall functions are not used.
> Do I need to add these functions together with driver part?
Yes, send functions together with the stuff which uses them pls.
Thx.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply. Srsly.
next prev parent reply other threads:[~2019-05-27 22:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 3:45 [PATCH v6 0/4] x86: Add the support of ACRN guest under x86 Zhao Yakui
2019-04-30 3:45 ` [PATCH v6 1/4] x86/Kconfig: Add new config symbol to unify conditional definition of hv_irq_callback_count Zhao Yakui
2019-04-30 3:45 ` [PATCH v6 2/4] x86: Add the support of Linux guest on ACRN hypervisor Zhao Yakui
2019-04-30 3:45 ` [PATCH v6 3/4] x86/acrn: Use HYPERVISOR_CALLBACK_VECTOR for ACRN guest upcall vector Zhao Yakui
2019-05-15 17:23 ` Borislav Petkov
2019-05-27 2:21 ` Zhao, Yakui
2019-05-27 22:43 ` Borislav Petkov
2019-04-30 3:45 ` [PATCH v6 4/4] x86/acrn: Add hypercall for ACRN guest Zhao Yakui
2019-05-15 7:37 ` Borislav Petkov
2019-05-27 2:57 ` Zhao, Yakui
2019-05-27 22:46 ` Borislav Petkov [this message]
2019-05-28 1:08 ` Zhao, Yakui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527224618.GB8209@cz.tnic \
--to=bp@alien8.de \
--cc=jason.cj.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox