From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F320FC04AB6 for ; Tue, 28 May 2019 08:59:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1E5B2075C for ; Tue, 28 May 2019 08:59:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726698AbfE1I7o (ORCPT ); Tue, 28 May 2019 04:59:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59572 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726279AbfE1I7o (ORCPT ); Tue, 28 May 2019 04:59:44 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3DD4E2E95A2; Tue, 28 May 2019 08:59:44 +0000 (UTC) Received: from krava (unknown [10.43.17.32]) by smtp.corp.redhat.com (Postfix) with SMTP id BF9745D9CD; Tue, 28 May 2019 08:59:42 +0000 (UTC) Date: Tue, 28 May 2019 10:59:42 +0200 From: Jiri Olsa To: kan.liang@linux.intel.com Cc: acme@kernel.org, jolsa@kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org, peterz@infradead.org, ak@linux.intel.com Subject: Re: [PATCH 3/3] perf header: Rename "sibling cores" to "sibling sockets" Message-ID: <20190528085942.GA27906@krava> References: <1558644081-17738-1-git-send-email-kan.liang@linux.intel.com> <1558644081-17738-3-git-send-email-kan.liang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1558644081-17738-3-git-send-email-kan.liang@linux.intel.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 28 May 2019 08:59:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 23, 2019 at 01:41:21PM -0700, kan.liang@linux.intel.com wrote: > From: Kan Liang > > The "sibling cores" actually shows the sibling CPUs of a socket. > The name "sibling cores" is very misleading. > > Rename "sibling cores" to "sibling sockets" by checking on die topology, I found that thread_siblings_list is deprecated/renamed to core_cpus_list.. we should keep that in mind and support both jirka > > Signed-off-by: Kan Liang > --- > tools/perf/Documentation/perf.data-file-format.txt | 2 +- > tools/perf/util/header.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt > index c731416..dd85163 100644 > --- a/tools/perf/Documentation/perf.data-file-format.txt > +++ b/tools/perf/Documentation/perf.data-file-format.txt > @@ -168,7 +168,7 @@ struct { > }; > > Example: > - sibling cores : 0-8 > + sibling sockets : 0-8 > sibling dies : 0-3 > sibling dies : 4-7 > sibling threads : 0-1 > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c > index faa1e38..eb79495 100644 > --- a/tools/perf/util/header.c > +++ b/tools/perf/util/header.c > @@ -1465,7 +1465,7 @@ static void print_cpu_topology(struct feat_fd *ff, FILE *fp) > str = ph->env.sibling_cores; > > for (i = 0; i < nr; i++) { > - fprintf(fp, "# sibling cores : %s\n", str); > + fprintf(fp, "# sibling sockets : %s\n", str); > str += strlen(str) + 1; > } > > -- > 2.7.4 >