From: Peter Zijlstra <peterz@infradead.org>
To: "Liang, Kan" <kan.liang@linux.intel.com>
Cc: mingo@kernel.org, acme@redhat.com, vincent.weaver@maine.edu,
linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com,
ak@linux.intel.com, jolsa@redhat.com, eranian@google.com
Subject: Re: [PATCH V2 1/3] perf/x86: Disable non generic regs for software/probe events
Date: Tue, 28 May 2019 16:05:18 +0200 [thread overview]
Message-ID: <20190528140518.GU2623@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <7c8d8998-4722-e059-d378-b8517193e32f@linux.intel.com>
On Tue, May 28, 2019 at 09:33:40AM -0400, Liang, Kan wrote:
> Uncore PMU doesn't support sampling. It will return -EINVAL.
> There is no regs support for counting. The request will be ignored.
>
> I think current check for uncore is good enough.
breakpoints then.. There's also no guarantee you covered all software
events, and the core rewrite will allow other per-task/sampling PMUs
too.
The approach you take is just not complete, don't do that.
next prev parent reply other threads:[~2019-05-28 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 19:07 [PATCH V2 1/3] perf/x86: Disable non generic regs for software/probe events kan.liang
2019-05-27 19:07 ` [PATCH V2 2/3] perf/x86/regs: Check reserved bits kan.liang
2019-05-27 19:07 ` [PATCH V2 3/3] perf regs x86: Use PERF_REG_NON_GENERIC_MASK kan.liang
2019-05-28 8:56 ` [PATCH V2 1/3] perf/x86: Disable non generic regs for software/probe events Peter Zijlstra
2019-05-28 13:33 ` Liang, Kan
2019-05-28 14:05 ` Peter Zijlstra [this message]
2019-05-28 14:14 ` Vince Weaver
2019-05-28 14:26 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528140518.GU2623@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox