From: Steven Rostedt <rostedt@goodmis.org>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: Daniel Bristot de Oliveira <bristot@redhat.com>,
linux-kernel@vger.kernel.org, williams@redhat.com,
daniel@bristot.me, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Matthias Kaehlcke <mka@chromium.org>,
Frederic Weisbecker <frederic@kernel.org>,
Yangtao Li <tiny.windzz@gmail.com>,
Tommaso Cucinotta <tommaso.cucinotta@santannapisa.it>
Subject: Re: [RFC 1/3] softirq: Use preempt_latency_stop/start to trace preemption
Date: Wed, 29 May 2019 08:22:48 -0400 [thread overview]
Message-ID: <20190529082248.76bb7a6c@oasis.local.home> (raw)
In-Reply-To: <20190529093056.GA146079@google.com>
On Wed, 29 May 2019 05:30:56 -0400
Joel Fernandes <joel@joelfernandes.org> wrote:
> Yes, I think so. Also this patch changes CALLER_ADDR0 passed to the
> tracepoint because there's one more level of a non-inlined function call
> in the call chain right? Very least the changelog should document this
> change in functional behavior, IMO.
This sounds more like a break in behavior not a functional change. I
guess moving it to a header and making it a static __always_inline
should be fine though.
-- Steve
next prev parent reply other threads:[~2019-05-29 12:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 15:16 [RFC 0/3] preempt_tracer: Fix preempt_disable tracepoint Daniel Bristot de Oliveira
2019-05-28 15:16 ` [RFC 1/3] softirq: Use preempt_latency_stop/start to trace preemption Daniel Bristot de Oliveira
2019-05-29 8:29 ` Peter Zijlstra
2019-05-29 9:30 ` Joel Fernandes
2019-05-29 12:22 ` Steven Rostedt [this message]
2019-06-04 10:39 ` Daniel Bristot de Oliveira
2019-06-04 12:01 ` Steven Rostedt
2019-05-28 15:16 ` [RFC 2/3] preempt_tracer: Disable IRQ while starting/stopping due to a preempt_counter change Daniel Bristot de Oliveira
2019-05-29 8:33 ` Peter Zijlstra
2019-05-29 9:40 ` Daniel Bristot de Oliveira
2019-05-29 10:20 ` Peter Zijlstra
2019-05-29 12:39 ` Steven Rostedt
2019-05-29 13:19 ` Peter Zijlstra
2019-05-29 13:29 ` Peter Zijlstra
2019-05-29 13:42 ` Steven Rostedt
2019-05-29 13:49 ` Peter Zijlstra
2019-05-29 13:58 ` Steven Rostedt
2019-05-29 13:51 ` Daniel Bristot de Oliveira
2019-05-29 18:21 ` Peter Zijlstra
2019-06-04 10:20 ` Daniel Bristot de Oliveira
2019-05-31 7:47 ` Joel Fernandes
2019-06-04 10:12 ` Daniel Bristot de Oliveira
2019-06-04 15:01 ` Steven Rostedt
2019-06-05 15:16 ` Joel Fernandes
2019-05-28 15:16 ` [RFC 3/3] preempt_tracer: Use a percpu variable to control traceble calls Daniel Bristot de Oliveira
2019-05-29 8:41 ` Peter Zijlstra
2019-05-29 9:48 ` Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529082248.76bb7a6c@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=bristot@redhat.com \
--cc=daniel@bristot.me \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mka@chromium.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tiny.windzz@gmail.com \
--cc=tommaso.cucinotta@santannapisa.it \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox