From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: <myungjoo.ham@samsung.com>, <patches@opensource.cirrus.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] extcon: arizona: Correct error handling on regmap_update_bits_check
Date: Wed, 29 May 2019 10:05:04 +0100 [thread overview]
Message-ID: <20190529090504.GG28362@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <92a28c6f-9c58-d762-f635-f5a93e602843@samsung.com>
On Wed, May 29, 2019 at 02:37:06PM +0900, Chanwoo Choi wrote:
> Hi,
>
> On 19. 5. 29. 오전 1:50, Charles Keepax wrote:
> > Ensure the case when regmap_update_bits_check fails and the change
> > variable is not updated is handled correctly.
> >
> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > ---
> > regmap_update_bits_check(arizona->regmap, ARIZONA_MIC_DETECT_1,
> > ARIZONA_MICD_ENA, 0,
>
> You better to check the return value as the part of this patch.
>
Ok I will add it, I hadn't as it was kinda pointless the driver
is being unbound and if this doesn't work the regulator stuff
will flag the error anyway. But I guess one more error message to
make it even more clear where the issue is can't hurt.
Thanks,
Charles
prev parent reply other threads:[~2019-05-29 9:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190528165025epcas5p41d2a0c9b244532709135ab96da73e27c@epcas5p4.samsung.com>
2019-05-28 16:50 ` [PATCH] extcon: arizona: Correct error handling on regmap_update_bits_check Charles Keepax
2019-05-29 5:37 ` Chanwoo Choi
2019-05-29 9:05 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529090504.GG28362@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox