Re: [PATCH] extcon: arizona: Correct error handling on regmap_update_bits_check

Charles Keepax
2019-05-29T09:05:10Z

On Wed, May 29, 2019 at 02:37:06PM +0900, Chanwoo Choi wrote:
> Hi,
>
> On 19. 5. 29. 오전 1:50, Charles Keepax wrote:
> > Ensure the case when regmap_update_bits_check fails and the change
> > variable is not updated is handled correctly.
> >
> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > ---
> > regmap_update_bits_check(arizona->regmap, ARIZONA_MIC_DETECT_1,
> > ARIZONA_MICD_ENA, 0,
>
> You better to check the return value as the part of this patch.
>

Ok I will add it, I hadn't as it was kinda pointless the driver
is being unbound and if this doesn't work the regulator stuff
will flag the error anyway. But I guess one more error message to
make it even more clear where the issue is can't hurt.

Thanks,
Charles