From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 160F7C28CC0 for ; Wed, 29 May 2019 09:58:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DDFFA208CB for ; Wed, 29 May 2019 09:58:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="C+ffkDjw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726761AbfE2J62 (ORCPT ); Wed, 29 May 2019 05:58:28 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:57592 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725990AbfE2J61 (ORCPT ); Wed, 29 May 2019 05:58:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=40Ww1U6jHSA8ZmRiYmC+C6BB0Qna+KOdSYwCoTc6YjQ=; b=C+ffkDjw2i3zSjdGxEQOsrfOH jSMeUDcWszjB+A92PhqCZvDq+vh8wGldURKlX1YAQwKZgkhMMvYqkFq8LGqKX8jva0zDJ3ORzSlsX MaKjQ+Ieoxv81e+y4Gsz6mFjtUNC0f3v1/DhP5Y8NWHiXxW3EGcVX3joDeTLdstcEjqZo0QRU5B+w EULJ8NsytdoVUO5LK8rAjtJr+wk4SofyiE316JL3oLdW1tsoiK9SEbFhTETQlgLJn6Z5HEyhBUWct VrDUO50e+8JUivouEmG0dgWrpCgem4+W55v+t5/wR9jl2mmkrTaXLluOEmoUTZgXHtK2lL7IbWt6I M1nRZeIBw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVvLc-0002EX-JV; Wed, 29 May 2019 09:58:16 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 22A822065C636; Wed, 29 May 2019 11:58:15 +0200 (CEST) Date: Wed, 29 May 2019 11:58:15 +0200 From: Peter Zijlstra To: Marco Elver Cc: Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , the arch/x86 maintainers , Arnd Bergmann , Josh Poimboeuf , "open list:DOCUMENTATION" , LKML , linux-arch , kasan-dev Subject: Re: [PATCH 2/3] tools/objtool: add kasan_check_* to uaccess whitelist Message-ID: <20190529095815.GL2623@hirez.programming.kicks-ass.net> References: <20190528163258.260144-1-elver@google.com> <20190528163258.260144-2-elver@google.com> <20190528171942.GV2623@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 29, 2019 at 11:46:10AM +0200, Marco Elver wrote: > On Wed, 29 May 2019 at 10:55, Dmitry Vyukov wrote: > > > > On Tue, May 28, 2019 at 7:19 PM Peter Zijlstra wrote: > > > > > > On Tue, May 28, 2019 at 06:32:57PM +0200, Marco Elver wrote: > > > > This is a pre-requisite for enabling bitops instrumentation. Some bitops > > > > may safely be used with instrumentation in uaccess regions. > > > > > > > > For example, on x86, `test_bit` is used to test a CPU-feature in a > > > > uaccess region: arch/x86/ia32/ia32_signal.c:361 > > > > > > That one can easily be moved out of the uaccess region. Any else? > > > > Marco, try to update config with "make allyesconfig" and then build > > the kernel without this change. > > > > Done. The only instance of the uaccess warning is still in > arch/x86/ia32/ia32_signal.c. > > Change the patch to move this access instead? Let me know what you prefer. Yes, I think that might be best. The whitelist should be minimal.