From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E32E5C28CC2 for ; Wed, 29 May 2019 17:01:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B391823E91 for ; Wed, 29 May 2019 17:01:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="jdAco6Qh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726372AbfE2RBA (ORCPT ); Wed, 29 May 2019 13:01:00 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:53612 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbfE2RA7 (ORCPT ); Wed, 29 May 2019 13:00:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Rql5GG/ybmT6SurmXd44Bjbh2qIVyT0VkM96NAFNiuY=; b=jdAco6Qh4fkIH/71oUSSsoO7u lk/BCu4M3STYvMP8qWc8qxfDNG9NRTTOJthuMX6pFjkDv51ePcJUUZhFoyOOUBAcneWneFAPIznKI uPXl855Y50siczUlOJg0ioKM4UHriKcxQK1MM2/2yL5RKdv/zePr5OceUBlFl3fnwwDpHMa2PH9pi SQ383xI5o8py9HY8VmcxItqK50zXYQOUehWpRfyEfVZAe6bA2Nh4Y/Qy7Va8E4pnJiQ9z8pb8iCs7 62/VcszK1uGMGe11Xy1e/cqBxPwvdYlJtzbkG6piUKJX6sQ0HEuvkaADhVIhIgQu66bcKacREQJLZ X3LzfNL8Q==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hW1wX-0001KV-Ov; Wed, 29 May 2019 17:00:49 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 281D7201B8CFE; Wed, 29 May 2019 19:00:48 +0200 (CEST) Date: Wed, 29 May 2019 19:00:48 +0200 From: Peter Zijlstra To: Jiri Kosina Cc: Josh Poimboeuf , "Rafael J. Wysocki" , Pavel Machek , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume Message-ID: <20190529170048.GD2623@hirez.programming.kicks-ass.net> References: <20190529161028.a6kpywzpjazgql5u@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 29, 2019 at 06:26:59PM +0200, Jiri Kosina wrote: > On Wed, 29 May 2019, Josh Poimboeuf wrote: > > Is there are reason why maxcpus= doesn't do the CR4.MCE booted_once > > dance? > > I am not sure whether it's really needed. My understanding is that the MCE > issue happens only after primary sibling has been brought up; if that > never happened, MCE wouldn't be broadcasted to that core at all in the > first place. > > But this needs to be confirmed by Intel. (I'm not confirming anything, as I've no clue), but that code stems from long before we found out about that brilliant MCE stuff (which was fairly recent).