Re: [PATCH] mm/slab_common.c: fix possible spectre-v1 in kmalloc_slab()

Matthew Wilcox
2019-05-30T00:04:48Z

On Wed, May 29, 2019 at 11:31:06PM +0300, Alexey Dobriyan wrote:
> > I think it makes more sense to sanitize size in size_index_elem(),
> > don't you?
>
> > - return (bytes - 1) / 8;
> > + return array_index_nospec((bytes - 1) / 8, ARRAY_SIZE(size_index));
>
> I think it should be fixed in poll.
> Literally every small variable kmalloc call is going through this function.

We could do that too, but don't we then have to audit every ioctl and
similar to see if there's a k(v)malloc based on a size passed from
userspace?