Re: [PATCH 1/7] General notification queue with user mmap()'able ring buffer

Peter Zijlstra
2019-06-17T16:25:18Z

On Fri, May 31, 2019 at 06:12:42PM +0100, David Howells wrote:
> Peter Zijlstra <peterz@infradead.org> wrote:
>
> > > > (and it has already been established that refcount_t doesn't work for
> > > > usage count scenarios)
> > >
> > > ?
> > >
> > > Does that mean struct kref doesn't either?
> >
> > Indeed, since kref is just a pointless wrapper around refcount_t it does
> > not either.
> >
> > The main distinction between a reference count and a usage count is that
> > 0 means different things. For a refcount 0 means dead. For a usage count
> > 0 is merely unused but valid.
>
> Ah - I consider the terms interchangeable.
>
> Take Documentation/filesystems/vfs.txt for instance:
>
> dget: open a new handle for an existing dentry (this just increments
> the usage count)
>
> dput: close a handle for a dentry (decrements the usage count). ...
>
> ...
>
> d_lookup: look up a dentry given its parent and path name component
> It looks up the child of that given name from the dcache
> hash table. If it is found, the reference count is incremented
> and the dentry is returned. The caller must use dput()
> to free the dentry when it finishes using it.
>
> Here we interchange the terms.
>
> Or https://www.kernel.org/doc/gorman/html/understand/understand013.html
> which seems to interchange the terms in reference to struct page.

Right, but we have two distinct set of semantics, I figured it makes
sense to have two different names for them. Do you have an alternative
naming scheme we could use?

Or should we better document our distinction between reference and usage
count?