From: "Theodore Ts'o" <tytso@mit.edu>
To: Trevor Bourget <tgb.kernel@gmail.com>
Cc: Jiri Slaby <jslaby@suse.cz>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
dhowells@redhat.com
Subject: Re: [PATCH] vt: configurable number of console devices
Date: Wed, 29 May 2019 19:31:46 -0400 [thread overview]
Message-ID: <20190529233146.GA3671@mit.edu> (raw)
In-Reply-To: <CAG0f_nYQSn8eFHH3EcV4zxia0C6v7PfCvXybx40em9KgtzMGqQ@mail.gmail.com>
On Wed, May 29, 2019 at 03:09:11PM -0700, Trevor Bourget wrote:
> Sorry, I hadn't registered that was uapi. You are right, as a
> configuration setting it's an odd thing to expose there.
> That define won't really be any use to user space except for type
> range validation, and as such it would actually be unhelpful for it to
> be other than 63.
>
> I will add if defined(__KERNEL__) to improve that, so that it will be
> constant for uapi.
It's by design that MAX_NR_CONSOLES is defined in a uapi header.
There are userspace programs that rely on this value (they use it to
declare arrays, so the version that we export to userspace MUST be
largest value that any kernel might support).
That being said, I've done an eyeball inspection to see how manytes
might be saved if we were to shirnk MAX_NR_CONSOLES, and... I don't
see that many bytes. Maybe 24 bytes per console, so that maximum
savings would less than 1.5k? Am I missing something?
Yes, we should all worry about kernel bloat; but it's not clear to me
this is a great place to start. :-)
- Ted
prev parent reply other threads:[~2019-05-29 23:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 4:31 [PATCH] vt: configurable number of console devices Trevor Bourget
2019-05-29 11:03 ` Jiri Slaby
2019-05-29 22:09 ` Trevor Bourget
2019-05-29 23:31 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529233146.GA3671@mit.edu \
--to=tytso@mit.edu \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=tgb.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).