From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CC47C28CC0 for ; Thu, 30 May 2019 03:38:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C858A24B82 for ; Thu, 30 May 2019 03:38:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559187528; bh=ES6TSm92Nr2A+PgfWeIlAtLSD3GvoIMI0jJW/rF6MS8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YQYZtSH9hZau48VFi3JbZyT15hHSUchf6rBJq9t3ppE1XCRLAzQx6+ww5BB37W8rP pMijY13dc8w4ggoWT06XxNpIcfJNHSbnoxbshPP5mc9Kcl+kLIlP8dLUc/obG9db+s 7fvEZhmJXZEFvGu6cjcFhOZmn/DnMbsRG3xyIWpw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732900AbfE3DWq (ORCPT ); Wed, 29 May 2019 23:22:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:44738 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730902AbfE3DRD (ORCPT ); Wed, 29 May 2019 23:17:03 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 954602465C; Thu, 30 May 2019 03:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186222; bh=ES6TSm92Nr2A+PgfWeIlAtLSD3GvoIMI0jJW/rF6MS8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2pR9UYYmCyhokBOna+HNZLaQpMIens7n81fgOAyUCuEEnjcUBA2xl5GV3wUhtUBsu cfAIYiYaWneBlGbIl2e3kwC9tqJWwuMMkh+HJQ/9qzNuClJy+VXAM2seXS77vbunCd VgPgPZ5ZDh/MG6CWoSR+JueqnpClu2XUPKLJ4Ucc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wen Yang , Linus Walleij , linux-gpio@vger.kernel.org, Sasha Levin Subject: [PATCH 4.19 116/276] pinctrl: pistachio: fix leaked of_node references Date: Wed, 29 May 2019 20:04:34 -0700 Message-Id: <20190530030533.171172569@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030523.133519668@linuxfoundation.org> References: <20190530030523.133519668@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 44a4455ac2c6b0981eace683a2b6eccf47689022 ] The call to of_get_child_by_name returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/pinctrl/pinctrl-pistachio.c:1422:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1360, but without a corresponding object release within this function. Signed-off-by: Wen Yang Cc: Linus Walleij Cc: linux-gpio@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/pinctrl-pistachio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-pistachio.c index 302190d1558d9..0d7d379e9bb80 100644 --- a/drivers/pinctrl/pinctrl-pistachio.c +++ b/drivers/pinctrl/pinctrl-pistachio.c @@ -1368,6 +1368,7 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl) if (!of_find_property(child, "gpio-controller", NULL)) { dev_err(pctl->dev, "No gpio-controller property for bank %u\n", i); + of_node_put(child); ret = -ENODEV; goto err; } @@ -1375,6 +1376,7 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl) irq = irq_of_parse_and_map(child, 0); if (irq < 0) { dev_err(pctl->dev, "No IRQ for bank %u: %d\n", i, irq); + of_node_put(child); ret = irq; goto err; } -- 2.20.1