From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Luwei Kang <luwei.kang@intel.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
pbonzini@redhat.com, rkrcmar@redhat.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org
Subject: Re: [PATCH] KVM: LAPIC: Do not mask the local interrupts when LAPIC is sw disabled
Date: Thu, 30 May 2019 11:46:02 -0700 [thread overview]
Message-ID: <20190530184602.GD23930@linux.intel.com> (raw)
In-Reply-To: <1558435455-233679-1-git-send-email-luwei.kang@intel.com>
On Tue, May 21, 2019 at 06:44:15PM +0800, Luwei Kang wrote:
> The current code will mask all the local interrupts in the local
> vector table when the LAPIC is disabled by SVR (Spurious-Interrupt
> Vector Register) "APIC Software Enable/Disable" flag (bit8).
> This may block local interrupt be delivered to target vCPU
> even if LAPIC is enabled by set SVR (bit8 == 1) after.
The current code aligns with the SDM, which states:
Local APIC State After It Has Been Software Disabled
When the APIC software enable/disable flag in the spurious interrupt
vector register has been explicitly cleared (as opposed to being cleared
during a power up or reset), the local APIC is temporarily disabled.
The operation and response of a local APIC while in this software-
disabled state is as follows:
- The mask bits for all the LVT entries are set. Attempts to reset
these bits will be ignored.
next prev parent reply other threads:[~2019-05-30 18:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 10:44 [PATCH] KVM: LAPIC: Do not mask the local interrupts when LAPIC is sw disabled Luwei Kang
2019-05-30 18:46 ` Sean Christopherson [this message]
2019-05-31 8:11 ` Kang, Luwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530184602.GD23930@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luwei.kang@intel.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox