From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F622C28CC0 for ; Thu, 30 May 2019 20:46:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20D182617A for ; Thu, 30 May 2019 20:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559249200; bh=3l/fBGXgNQ3z54neldfhfMe6aZgeoJlVyXU0AaAwnio=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=YlQViF6qo9Dj4xQoe6G95nKwpT5CA/S735LGK/DYiaP3gQuHR2MrTPnWE+GBPAUgA qsEcCAqr1w/mxe/GrM5/nq25X89oJSfc8T/xxIUCdCdg5DK785AhrEgsGx0eLc+L6Y Ke5Pc2NayatbQ/oOugoQwDvtV2c/QLVSvtU3Vaww= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726540AbfE3Uqj (ORCPT ); Thu, 30 May 2019 16:46:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:52472 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726169AbfE3Uqj (ORCPT ); Thu, 30 May 2019 16:46:39 -0400 Received: from localhost (unknown [207.225.69.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 471722617A; Thu, 30 May 2019 20:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559249198; bh=3l/fBGXgNQ3z54neldfhfMe6aZgeoJlVyXU0AaAwnio=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=v2pCGD1jqzExF0Y6VZpFYt1i0aBb2vFESyML1kkiCIWUs+pjHG6XtXbVHLl2EVijj BPpjNLOPwnr4zqUnkCf/x7hqMD+CaVljtHhdHFyBj1AcxfemywLbyFdg0YxXlX7x0e 6FJIMcqspp4XZ2rNP9jiDTQ9BLMjDT3ZOje9k6gs= Date: Thu, 30 May 2019 13:46:38 -0700 From: Greg KH To: Nishka Dasgupta Cc: digetx@gmail.com, mchehab@kernel.org, thierry.reding@gmail.com, jonathan@nvidia.com, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: media: tegra-vde: Remove variable Message-ID: <20190530204638.GA4784@kroah.com> References: <20190530204439.29830-1-nishkadg.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190530204439.29830-1-nishkadg.linux@gmail.com> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 31, 2019 at 02:14:39AM +0530, Nishka Dasgupta wrote: > Remove unnecessary variable iram_tables and use its value directly. > Issue found using Coccinelle. > > Signed-off-by: Nishka Dasgupta > --- > drivers/staging/media/tegra-vde/tegra-vde.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/media/tegra-vde/tegra-vde.c b/drivers/staging/media/tegra-vde/tegra-vde.c > index a5020dbf6eef..3205973218e4 100644 > --- a/drivers/staging/media/tegra-vde/tegra-vde.c > +++ b/drivers/staging/media/tegra-vde/tegra-vde.c > @@ -273,12 +273,10 @@ static void tegra_vde_setup_iram_entry(struct tegra_vde *vde, > unsigned int row, > u32 value1, u32 value2) > { > - u32 *iram_tables = vde->iram; > - > trace_vde_setup_iram_entry(table, row, value1, value2); > > - iram_tables[0x20 * table + row * 2] = value1; > - iram_tables[0x20 * table + row * 2 + 1] = value2; > + vde->iram[0x20 * table + row * 2] = value1; > + vde->iram[0x20 * table + row * 2 + 1] = value2; Ick, no, why? why why why? You keep sending these patches, please take a bit of time to think about what you are doing and see if the change actually makes sense. Again, here, no, it does not. greg k-h