From: Greg KH <gregkh@linuxfoundation.org>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: hans.verkuil@cisco.com, mchehab@kernel.org, code@wizofe.uk,
ezequiel@collabora.com, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: davinci_vpfe: Remove variable vpfe_dev
Date: Thu, 30 May 2019 13:55:40 -0700 [thread overview]
Message-ID: <20190530205540.GA5308@kroah.com> (raw)
In-Reply-To: <20190530204718.29892-1-nishkadg.linux@gmail.com>
On Fri, May 31, 2019 at 02:17:18AM +0530, Nishka Dasgupta wrote:
> Remove variable vpfe_dev and replace it with its value (since the
> function otherwise uses values directly instead of local variables).
This says _what_ you do. But we can see that in the patch itself.
You need to say _why_ you are doing this.
There's no need for this change at all. Again, as I have said before,
we write code for developers to read first, the compiler second. By
making these types of changes you are making it harder to
read/understand by a developer, and providing absolutely no benifit to
the compiler at all.
So it's actually making the code worse!
not good at all.
Please reconsider this type of change, as I keep asking you to.
greg k-h
next prev parent reply other threads:[~2019-05-30 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 20:47 [PATCH] staging: media: davinci_vpfe: Remove variable vpfe_dev Nishka Dasgupta
2019-05-30 20:55 ` Greg KH [this message]
2019-05-30 21:09 ` Nishka Dasgupta
2019-05-30 21:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530205540.GA5308@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=code@wizofe.uk \
--cc=devel@driverdev.osuosl.org \
--cc=ezequiel@collabora.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nishkadg.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox