Re: [RFC PATCH v2 07/12] smp: Do not mark call_function_data as shared

Nadav Amit
2019-05-31T17:50:38Z

> On May 31, 2019, at 3:17 AM, Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Thu, May 30, 2019 at 11:36:40PM -0700, Nadav Amit wrote:
>> cfd_data is marked as shared, but although it hold pointers to shared
>> data structures, it is private per core.
>>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Rik van Riel <riel@surriel.com>
>> Cc: Andy Lutomirski <luto@kernel.org>
>> Signed-off-by: Nadav Amit <namit@vmware.com>
>> ---
>> kernel/smp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/smp.c b/kernel/smp.c
>> index 6b411ee86ef6..f1a358f9c34c 100644
>> --- a/kernel/smp.c
>> +++ b/kernel/smp.c
>> @@ -33,7 +33,7 @@ struct call_function_data {
>> cpumask_var_t cpumask_ipi;
>> };
>>
>> -static DEFINE_PER_CPU_SHARED_ALIGNED(struct call_function_data, cfd_data);
>> +static DEFINE_PER_CPU(struct call_function_data, cfd_data);
>
> Should that not be DEFINE_PER_CPU_ALIGNED() then?

Yes. I don’t know what I was thinking. I’ll change it.