From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0FB6C04AB6 for ; Fri, 31 May 2019 14:38:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8805726AB9 for ; Fri, 31 May 2019 14:38:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559313483; bh=BDjm7pEDdEXPIX9H5qMwxiK+c8NtDxwUnmEORHK/zVE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=xOaX1q+pcg6H0lfp/eBA6ERyXi+7nRNqN+I4uhP/3CSG37xanRkuJav5InHyUfgIQ PypAxV9gmW+kW7VGW8a7DHMkCEQUrdNyFJ/yehvz6u0pVQr34QGb4+emcWLNMc6e9U mYAHp7yibwRw0WAUfHNrkSn+avsuReWm/4MFWINM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726725AbfEaOiC (ORCPT ); Fri, 31 May 2019 10:38:02 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:35262 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726037AbfEaOiC (ORCPT ); Fri, 31 May 2019 10:38:02 -0400 Received: by mail-qt1-f193.google.com with SMTP id d23so1141912qto.2 for ; Fri, 31 May 2019 07:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=649G8fX5KsyxKNGqC8JgOTPtl/EUKZLecJRl6sV4WuE=; b=gcp92TBDfc0rnUPM9YcSJPS63vLFPmXlbELISOregSWXFow0wkuMKoNUTCwWuPETjn 58EjhTjW0OS5FGcgpplBpmIsKAOKOj5yz/RM0/7byNNAcT83+i2IcZsyAxLeRThi8iBD u/ot7JwaMWPkMOswd8p5V6fcx1AJBQj6oUxJAE5RR0Tljh4eGxulZ9VkS0R88KQxf1yf JMUjXaFl5Rle0cxtVYfNp08eqHZW6Gw8Z9WvlWbFaiyaCQ2i9xdlsZ6WM3u1pkc46Jyz Nx3amfFonmYF8TqE1rNIL3DAei2V1sqrXokli290xrfi41tdLCckSjNVEAmNr1IvZiIA BZaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=649G8fX5KsyxKNGqC8JgOTPtl/EUKZLecJRl6sV4WuE=; b=B5Zg1xaCTnP1sy1AbaGaORjdKPxEJvMPf6Kd6n6crAckyxJdE2Qy/RSUVelvoVsdbb erenSVT90yRzypjgEMhPOuo20lBhU8Ea4gf/CxDItdtsWRJWO1qAMesKgmY9wiLiuuR8 2IrYT5RmzWBNXPkKKAd6/p/aDFE4MZPl3bu3cV6dZEMFG0DFnnNBiLVwr0l3pEq+zUYE PJ+6H/1OtSQOMVCZNINcx/G9utlIL6CQOM0f2d+Xnxk9sLCC6BRFM7uh1GI+z+Z/PFjJ /WT9NpcTHMrvxgzBHcFoEf6/3SXshwmqCfVMZn+TVAVfzWV2/LFD3duXu7nTC1W49xie D6bw== X-Gm-Message-State: APjAAAUkqseMAk5GBhfOGoUAaCQQFJawBeP8YUtop0V3m9va/b8y7USV pa4Elr7ivwkXcekArvnqFHo= X-Google-Smtp-Source: APXvYqygj+noRfQ7ZarPTbIglLApJBmc4ARIM2HfmB8bcs4XGAPQh8P9oPNnFyjrBYBZ687Y1rT0Pw== X-Received: by 2002:a0c:878e:: with SMTP id 14mr9262652qvj.103.1559313481179; Fri, 31 May 2019 07:38:01 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::39c9]) by smtp.gmail.com with ESMTPSA id v195sm3201216qka.28.2019.05.31.07.38.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 May 2019 07:38:00 -0700 (PDT) Date: Fri, 31 May 2019 07:37:59 -0700 From: Tejun Heo To: Gao Xiang Cc: Andrew Morton , Ingo Molnar , LKML , Peter Zijlstra Subject: Re: [PATCH] sched/core: add __sched tag for io_schedule() Message-ID: <20190531143759.GD374014@devbig004.ftw2.facebook.com> References: <20190531082912.80724-1-gaoxiang25@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190531082912.80724-1-gaoxiang25@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 31, 2019 at 04:29:12PM +0800, Gao Xiang wrote: > non-inline io_schedule() was introduced in > commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()") > Keep in line with io_schedule_timeout, Otherwise > "/proc//wchan" will report io_schedule() > rather than its callers when waiting io. > > Reported-by: Jilong Kou > Cc: Tejun Heo > Cc: Ingo Molnar > Cc: Peter Zijlstra > Signed-off-by: Gao Xiang Acked-by: Tejun Heo Thanks. -- tejun