From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] s390: drop unneeded -Wall addition from tools Makefile
Date: Sat, 1 Jun 2019 12:21:37 +0200 [thread overview]
Message-ID: <20190601102137.GC3600@osiris> (raw)
In-Reply-To: <20190517075428.13496-2-yamada.masahiro@socionext.com>
On Fri, May 17, 2019 at 04:54:25PM +0900, Masahiro Yamada wrote:
> The top level Makefile adds -Wall globally for all host tools:
>
> KBUILD_HOSTCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 \
>
> I see two "-Wall" added for compiling these tools.
>
> Of course, it is allowed to pass the same option multiple times, but
> we do not need to do so.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/s390/tools/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile
> index 4ff6a2124522..8fb66c99840a 100644
> --- a/arch/s390/tools/Makefile
> +++ b/arch/s390/tools/Makefile
> @@ -14,8 +14,7 @@ kapi: $(kapi-hdrs-y)
> hostprogs-y += gen_facilities
> hostprogs-y += gen_opcode_table
>
> -HOSTCFLAGS_gen_facilities.o += -Wall $(LINUXINCLUDE)
> -HOSTCFLAGS_gen_opcode_table.o += -Wall
> +HOSTCFLAGS_gen_facilities.o += $(LINUXINCLUDE)
Applied, thanks.
next prev parent reply other threads:[~2019-06-01 10:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 7:54 [PATCH 1/4] s390: do not pass $(LINUXINCLUDE) to gen_opcode_table.c Masahiro Yamada
2019-05-17 7:54 ` [PATCH 2/4] s390: drop unneeded -Wall addition from tools Makefile Masahiro Yamada
2019-06-01 10:21 ` Heiko Carstens [this message]
2019-05-17 7:54 ` [PATCH 3/4] s390: drop redundant directory creation " Masahiro Yamada
2019-06-01 10:21 ` Heiko Carstens
2019-05-17 7:54 ` [PATCH 4/4] s390: drop meaningless 'targets' " Masahiro Yamada
2019-06-01 10:22 ` Heiko Carstens
2019-06-01 10:21 ` [PATCH 1/4] s390: do not pass $(LINUXINCLUDE) to gen_opcode_table.c Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190601102137.GC3600@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox