From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04F40C28CC4 for ; Sat, 1 Jun 2019 10:22:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCA39271DC for ; Sat, 1 Jun 2019 10:22:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727164AbfFAKWF (ORCPT ); Sat, 1 Jun 2019 06:22:05 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:48518 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727048AbfFAKWF (ORCPT ); Sat, 1 Jun 2019 06:22:05 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x51AHECJ107024 for ; Sat, 1 Jun 2019 06:22:04 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2sunj42vh5-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 01 Jun 2019 06:22:04 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 1 Jun 2019 11:22:02 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sat, 1 Jun 2019 11:21:58 +0100 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x51ALvCd31064252 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 1 Jun 2019 10:21:57 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A4CB342041; Sat, 1 Jun 2019 10:21:57 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 796664203F; Sat, 1 Jun 2019 10:21:57 +0000 (GMT) Received: from osiris (unknown [9.152.212.21]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Sat, 1 Jun 2019 10:21:57 +0000 (GMT) Date: Sat, 1 Jun 2019 12:21:56 +0200 From: Heiko Carstens To: Masahiro Yamada Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] s390: drop redundant directory creation from tools Makefile References: <20190517075428.13496-1-yamada.masahiro@socionext.com> <20190517075428.13496-3-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190517075428.13496-3-yamada.masahiro@socionext.com> X-TM-AS-GCONF: 00 x-cbid: 19060110-0012-0000-0000-00000321816F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19060110-0013-0000-0000-0000215A562E Message-Id: <20190601102156.GD3600@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-01_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=689 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906010076 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 17, 2019 at 04:54:26PM +0900, Masahiro Yamada wrote: > As you can see in scripts/Kbuild.include, the filechk creates the > parent directory of the target as needed. > > This Makefile does not need to explicitly create the directory. > > Signed-off-by: Masahiro Yamada > --- > > arch/s390/tools/Makefile | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile > index 8fb66c99840a..4864ea5e6ceb 100644 > --- a/arch/s390/tools/Makefile > +++ b/arch/s390/tools/Makefile > @@ -16,9 +16,6 @@ hostprogs-y += gen_opcode_table > > HOSTCFLAGS_gen_facilities.o += $(LINUXINCLUDE) > > -# Ensure output directory exists > -_dummy := $(shell [ -d '$(kapi)' ] || mkdir -p '$(kapi)') > - Applied, thanks.