From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 377D4C28CC1 for ; Sat, 1 Jun 2019 10:23:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 150FA271DC for ; Sat, 1 Jun 2019 10:23:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727107AbfFAKXq (ORCPT ); Sat, 1 Jun 2019 06:23:46 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:40614 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726130AbfFAKXp (ORCPT ); Sat, 1 Jun 2019 06:23:45 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x51ANfjg109361 for ; Sat, 1 Jun 2019 06:23:44 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 2sunds38x0-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 01 Jun 2019 06:23:43 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 1 Jun 2019 11:22:19 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sat, 1 Jun 2019 11:22:16 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x51AMFpt63176856 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 1 Jun 2019 10:22:15 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 71FE0AE04D; Sat, 1 Jun 2019 10:22:15 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4694FAE045; Sat, 1 Jun 2019 10:22:15 +0000 (GMT) Received: from osiris (unknown [9.152.212.21]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Sat, 1 Jun 2019 10:22:15 +0000 (GMT) Date: Sat, 1 Jun 2019 12:22:13 +0200 From: Heiko Carstens To: Masahiro Yamada Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] s390: drop meaningless 'targets' from tools Makefile References: <20190517075428.13496-1-yamada.masahiro@socionext.com> <20190517075428.13496-4-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190517075428.13496-4-yamada.masahiro@socionext.com> X-TM-AS-GCONF: 00 x-cbid: 19060110-0012-0000-0000-000003218177 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19060110-0013-0000-0000-0000215A5638 Message-Id: <20190601102213.GE3600@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-01_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=854 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906010077 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 17, 2019 at 04:54:27PM +0900, Masahiro Yamada wrote: > 'targets' should be specified to include .*.cmd files to evaluate > if_changed or friends. > > Here, facility-defs.h and dis-defs.h are generated by filechk. > > Because filechk does not generate .*.cmd file, the 'targets' addition > is meaningless. The filechk correctly updates the target when its > content is changed. > > Signed-off-by: Masahiro Yamada > --- > > arch/s390/tools/Makefile | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile > index 4864ea5e6ceb..b5e35e8f999a 100644 > --- a/arch/s390/tools/Makefile > +++ b/arch/s390/tools/Makefile > @@ -6,7 +6,6 @@ > kapi := arch/$(ARCH)/include/generated/asm > kapi-hdrs-y := $(kapi)/facility-defs.h $(kapi)/dis-defs.h > > -targets += $(addprefix ../../../,$(kapi-hdrs-y)) Applied, thanks.