From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4307FC46470 for ; Sat, 1 Jun 2019 13:17:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 130DA2725F for ; Sat, 1 Jun 2019 13:17:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559395037; bh=tcNmDS2dYfT0+toW5BTsfBTpVZ2j+T3dVc+NEoQiLYc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=QSWsU6TKzec73pWj6ULqWzuWwsLdopUdFfl9S/xzi9i7W7eRWHv0qU0Y+dYgKhk0p UFZLGllfTfjlz5qpX+jtc7kpE0AqVSZtfjT2oIODKmY9OAHZqQxVgqkKoXkunsCIDi B/rvEyLiL0fBX9jEBSSZEajLOYHAXSeh6JhjshG8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727358AbfFANRQ (ORCPT ); Sat, 1 Jun 2019 09:17:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:41846 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727269AbfFANRH (ORCPT ); Sat, 1 Jun 2019 09:17:07 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2A5B2725E; Sat, 1 Jun 2019 13:17:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559395026; bh=tcNmDS2dYfT0+toW5BTsfBTpVZ2j+T3dVc+NEoQiLYc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z3hNBJh5t9+k3cevH0is/455tORRtsD3EZraPdkozFVeal600QkC0qQBU2aDNh7V8 ZLUCXTs2zXZJgeUSYFvVTeA2i8CLivEwX2E0FIujpxoH7c+Bxc0gs7cB8qgDncNdYi BEOM55ItDfokLOfl1dgFr7zwVR0VCBZdT1UUVO5M= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hou Tao , OGAWA Hirofumi , Al Viro , Jan Kara , Andrew Morton , Linus Torvalds , Sasha Levin Subject: [PATCH AUTOSEL 5.1 004/186] fs/fat/file.c: issue flush after the writeback of FAT Date: Sat, 1 Jun 2019 09:13:40 -0400 Message-Id: <20190601131653.24205-4-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190601131653.24205-1-sashal@kernel.org> References: <20190601131653.24205-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hou Tao [ Upstream commit bd8309de0d60838eef6fb575b0c4c7e95841cf73 ] fsync() needs to make sure the data & meta-data of file are persistent after the return of fsync(), even when a power-failure occurs later. In the case of fat-fs, the FAT belongs to the meta-data of file, so we need to issue a flush after the writeback of FAT instead before. Also bail out early when any stage of fsync fails. Link: http://lkml.kernel.org/r/20190409030158.136316-1-houtao1@huawei.com Signed-off-by: Hou Tao Acked-by: OGAWA Hirofumi Cc: Al Viro Cc: Jan Kara Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- fs/fat/file.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/fs/fat/file.c b/fs/fat/file.c index b3bed32946b1d..0e3ed79fcc3f1 100644 --- a/fs/fat/file.c +++ b/fs/fat/file.c @@ -193,12 +193,17 @@ static int fat_file_release(struct inode *inode, struct file *filp) int fat_file_fsync(struct file *filp, loff_t start, loff_t end, int datasync) { struct inode *inode = filp->f_mapping->host; - int res, err; + int err; + + err = __generic_file_fsync(filp, start, end, datasync); + if (err) + return err; - res = generic_file_fsync(filp, start, end, datasync); err = sync_mapping_buffers(MSDOS_SB(inode->i_sb)->fat_inode->i_mapping); + if (err) + return err; - return res ? res : err; + return blkdev_issue_flush(inode->i_sb->s_bdev, GFP_KERNEL, NULL); } -- 2.20.1