public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Deepak Mishra <linux.dkm@gmail.com>
Cc: linux-kernel@vger.kernel.org, joe@perches.com,
	wlanfae@realtek.com, Larry.Finger@lwfinger.net,
	florian.c.schilhabel@googlemail.com, himadri18.07@gmail.com,
	straube.linux@gmail.com
Subject: Re: [PATCH v2 5/9] staging: rtl8712: Fixed CamelCase renames IsrContent to isr_content
Date: Sun, 2 Jun 2019 19:13:00 +0200	[thread overview]
Message-ID: <20190602171300.GC19671@kroah.com> (raw)
In-Reply-To: <c56907d81f9452eec28f7b26eac54df185fb5735.1559470738.git.linux.dkm@gmail.com>

On Sun, Jun 02, 2019 at 03:55:34PM +0530, Deepak Mishra wrote:
> This patch fixes CamelCase IsrContent to isr_content as suggested by
> checkpatch.pl
> 
> Signed-off-by: Deepak Mishra <linux.dkm@gmail.com>
> ---
>  drivers/staging/rtl8712/drv_types.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
> index 5360f049088a..a5060a020b2b 100644
> --- a/drivers/staging/rtl8712/drv_types.h
> +++ b/drivers/staging/rtl8712/drv_types.h
> @@ -148,7 +148,7 @@ struct _adapter {
>  	bool	driver_stopped;
>  	bool	surprise_removed;
>  	bool	suspended;
> -	u32	IsrContent;
> +	u32	isr_content;
>  	u32	imr_content;
>  	u8	eeprom_address_size;
>  	u8	hw_init_completed;

Same comment here, just remove unused variables.  Is this structure even
ever used anywhere?

thanks,

greg k-h

  reply	other threads:[~2019-06-02 17:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-02 10:25 [PATCH v2 0/9] staging: rtl8712: Fixed CamelCase in struct _adapter Deepak Mishra
2019-06-02 10:25 ` [PATCH v2 1/9] staging: rtl8712: Fixed CamelCase rename ImrContent to imr_content Deepak Mishra
2019-06-02 17:11   ` Greg KH
2019-06-02 10:25 ` [PATCH v2 2/9] staging: rtl8712: Fixed CamelCase EepromAddressSize rename to eeprom_address_size Deepak Mishra
2019-06-02 10:25 ` [PATCH v2 3/9] staging: rtl8712: Fixed CamelCase cmdThread rename to cmd_thread Deepak Mishra
2019-06-02 10:25 ` [PATCH v2 4/9] staging: rtl8712: Fixed CamelCase renames evtThread to evt_thread Deepak Mishra
2019-06-02 17:12   ` Greg KH
2019-06-02 10:25 ` [PATCH v2 5/9] staging: rtl8712: Fixed CamelCase renames IsrContent to isr_content Deepak Mishra
2019-06-02 17:13   ` Greg KH [this message]
2019-06-02 10:25 ` [PATCH v2 6/9] staging: rtl8712: Fixed CamelCase renames xmitThread and recvThread Deepak Mishra
2019-06-02 17:13   ` Greg KH
2019-06-02 10:25 ` [PATCH v2 7/9] staging: rtl8712: Fixed CamelCase wkFilterRxFF0 to wk_filter_rx_ff0 in Deepak Mishra
2019-06-02 10:25 ` [PATCH v2 8/9] staging: rtl8712: fixed enable_rx_ff0_filter as bool and CamelCase Deepak Mishra
2019-06-02 17:14   ` Greg KH
2019-06-04  4:19     ` Deepak Kumar Mishra
2019-06-02 10:25 ` [PATCH v2 9/9] staging: rtl8712: Fixed CamelCase lockRxFF0Filter Deepak Mishra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190602171300.GC19671@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=himadri18.07@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux.dkm@gmail.com \
    --cc=straube.linux@gmail.com \
    --cc=wlanfae@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox