From: Sam Ravnborg <sam@ravnborg.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, od@zcrc.me
Subject: Re: [PATCH 1/2] dt-bindings: display: Add King Display KD035G6-54NT panel documentation
Date: Sun, 2 Jun 2019 20:23:19 +0200 [thread overview]
Message-ID: <20190602182319.GA10060@ravnborg.org> (raw)
In-Reply-To: <20190602164844.15659-1-paul@crapouillou.net>
Hi Paul.
As already said on irc, maybe add:
"The generic bindings for the SPI slaves documented in [1] also applies"
as we see other binding using spi already does.
Looking at: sitronix,st7789v.txt
should reg also be specified as required here?
Sam
On Sun, Jun 02, 2019 at 06:48:43PM +0200, Paul Cercueil wrote:
> The KD035G6-54NT is a 3.5" 320x240 24-bit TFT LCD panel.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> .../panel/kingdisplay,kd035g6-54nt.txt | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.txt
>
> diff --git a/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.txt b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.txt
> new file mode 100644
> index 000000000000..a6e4a9af4925
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.txt
> @@ -0,0 +1,27 @@
> +King Display KD035G6-54NT 3.5" (320x240 pixels) 24-bit TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "kingdisplay,kd035g6-54nt"
> +- power-supply: See panel-common.txt
> +- reset-gpios: See panel-common.txt
> +
> +Optional properties:
> +- backlight: see panel-common.txt
> +
> +Example:
> +
> +&spi {
> + display-panel {
> + compatible = "kingdisplay,kd035g6-54nt";
> + reg = <0>;
> +
> + spi-max-frequency = <3125000>;
> + spi-3wire;
> + spi-cs-high;
> +
> + reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>;
> +
> + backlight = <&backlight>;
> + power-supply = <&ldo6>;
> + };
> +};
> --
> 2.21.0.593.g511ec345e18
prev parent reply other threads:[~2019-06-02 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 16:48 [PATCH 1/2] dt-bindings: display: Add King Display KD035G6-54NT panel documentation Paul Cercueil
2019-06-02 16:48 ` [PATCH 2/2] drm/panel: Add Novatek NT39016 panel support Paul Cercueil
2019-06-02 18:44 ` Sam Ravnborg
2019-06-03 9:58 ` Maarten ter Huurne
2019-06-02 18:23 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190602182319.GA10060@ravnborg.org \
--to=sam@ravnborg.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox