Re: [PATCH v2] sched/core: add __sched tag for io_schedule()

Gao Xiang
2019-06-12T11:34:30Z

Friendly ping...

Thanks,
Gao Xiang

On 2019/6/3 17:13, Gao Xiang wrote:
> non-inline io_schedule() was introduced in
> commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
> Keep in line with io_schedule_timeout, Otherwise
> "/proc/<pid>/wchan" will report io_schedule()
> rather than its callers when waiting io.
>
> Reported-by: Jilong Kou <koujilong@huawei.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Acked-by: Tejun Heo <tj@kernel.org>
> Fixes: 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
> Cc: <stable@vger.kernel.org> # 4.11+
> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
> ---
> change log v2:
> - add missing tags
>
> kernel/sched/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 874c427742a9..4d5962232a55 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -5123,7 +5123,7 @@ long __sched io_schedule_timeout(long timeout)
> }
> EXPORT_SYMBOL(io_schedule_timeout);
>
> -void io_schedule(void)
> +void __sched io_schedule(void)
> {
> int token;
>
>