From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03471C04AB5 for ; Mon, 3 Jun 2019 12:16:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BAFA7280C1 for ; Mon, 3 Jun 2019 12:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559564207; bh=wulgFJ3+yhHuyD9dxZ/TbsHdJm7qURFTPLhJyoQxgw0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=NAiUu49KmDTVc6kCceH7BgyXRzjmYae5utMXamYrqh0NKgx81elwrWdOX8NU9wZ+J fHLn5/5WDwp9ylGvIdepEsBVSwvJ5wBP1YXMv0S6SOyKwp/ZeqamM6KfkPhiK+B6VE NAmlr3FN4RXtGIew2vcbByo0DTE9ZF0jYtU0RpGY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727591AbfFCMQq (ORCPT ); Mon, 3 Jun 2019 08:16:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:47342 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726587AbfFCMQq (ORCPT ); Mon, 3 Jun 2019 08:16:46 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3DBB8280C0; Mon, 3 Jun 2019 12:16:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559564205; bh=wulgFJ3+yhHuyD9dxZ/TbsHdJm7qURFTPLhJyoQxgw0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GbX3eLZzOyim2Gyqv5jHF5jIvDinNpRiZiEfETW6gw+ijDjYfdyRBe0n3kS2OEyGw 8BhbmNSlhBrWU0h8ZyKGKlQUhNyJhC5217gPeVRJUoairtqivdjOlLLmFI+5CXAqao gx80KM8zMSRxHSL9g/LMFg2gVWMvwk2ARWFFO0jk= Date: Mon, 3 Jun 2019 14:16:43 +0200 From: Greg Kroah-Hartman To: Geordan Neukum Cc: devel@driverdev.osuosl.org, YueHaibing , Mao Wenan , linux-kernel@vger.kernel.org, Nathan Chancellor , Dan Carpenter Subject: Re: [PATCH 5/5] staging: kpc2000: kpc_spi: use devm_* API to manage mapped I/O space Message-ID: <20190603121643.GA25274@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 02, 2019 at 03:58:37PM +0000, Geordan Neukum wrote: > The kpc_spi driver does not unmap its I/O space upon error cases in the > probe() function or upon remove(). Make the driver clean up after itself > more maintainably by migrating to using the managed resource API. > > Signed-off-by: Geordan Neukum > --- > drivers/staging/kpc2000/kpc2000_spi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c > index b513432a26ed..32d3ec532e26 100644 > --- a/drivers/staging/kpc2000/kpc2000_spi.c > +++ b/drivers/staging/kpc2000/kpc2000_spi.c > @@ -471,7 +471,8 @@ kp_spi_probe(struct platform_device *pldev) > goto free_master; > } > > - kpspi->phys = (unsigned long)ioremap_nocache(r->start, resource_size(r)); > + kpspi->phys = (unsigned long)devm_ioremap_nocache(&pldev->dev, r->start, > + resource_size(r)); Why is this being cast? This should just be an __iomem *, right? > kpspi->base = (u64 __iomem *)kpspi->phys; Then that cast will go away :) Anyway, something for a future patch, this one is fine, thanks. greg k-h