From: Greg KH <gregkh@linuxfoundation.org>
To: "Christian Müller" <muellerch-privat@web.de>
Cc: devel@driverdev.osuosl.org, felix.trommer@hotmail.de,
linux-kernel@i4.cs.fau.de, linux-kernel@vger.kernel.org,
johnfwhitmore@gmail.com
Subject: Re: [PATCH 1/3] drivers/staging/rtl8192u: Reformat comments
Date: Mon, 3 Jun 2019 15:04:37 +0200 [thread overview]
Message-ID: <20190603130437.GA30732@kroah.com> (raw)
In-Reply-To: <20190603122104.2564-2-muellerch-privat@web.de>
On Mon, Jun 03, 2019 at 02:21:02PM +0200, Christian Müller wrote:
> From: Felix Trommer <felix.trommer@hotmail.de>
>
> Replace C99-Style comments with C89-Style comments.
What does that mean?
> if (MaxChnlNum >= pTriple->first_channel) {
> - /* It is not in a monotonically increasing order, so
> + /*
> + * It is not in a monotonically increasing order, so
> * stop processing.
> */
Those are both /* */ style comments. Where in the C99 or C89 spec does
it say anything about this type of change?
Are you sure you are not getting confused about // for a comment marker
in C99 which is not in C89?
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-03 13:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 12:21 [PATCH 0/3] Fixing style errors in staging/drivers/rtl8192u Christian Müller
2019-06-03 12:21 ` [PATCH 1/3] drivers/staging/rtl8192u: Reformat comments Christian Müller
2019-06-03 13:04 ` Greg KH [this message]
2019-06-03 12:21 ` [PATCH 2/3] drivers/staging/rtl8192u: Remove comment-out code Christian Müller
2019-06-03 13:06 ` Greg KH
2019-06-03 12:21 ` [PATCH 3/3] drivers/staging/rtl8192u: Fix of checkpatch-errors Christian Müller
2019-06-03 13:05 ` Greg KH
2019-06-03 13:09 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603130437.GA30732@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=felix.trommer@hotmail.de \
--cc=johnfwhitmore@gmail.com \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=muellerch-privat@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox