From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2408C04AB5 for ; Mon, 3 Jun 2019 13:22:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9534027DAC for ; Mon, 3 Jun 2019 13:22:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="5V1h9xk2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728630AbfFCNWM (ORCPT ); Mon, 3 Jun 2019 09:22:12 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50356 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727707AbfFCNWM (ORCPT ); Mon, 3 Jun 2019 09:22:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VBTaQTRRFJk9ShP9IjlzRSGL8L3GcMXx/V92hcLsIJk=; b=5V1h9xk2eg5rUFfi6oHhFoZutF E32KrnWqwiGFdQxxf6+rttQm+8jmiSFLI3X0pyfQm9Qgf+96W7rf7Bal2zDbTUCfTXq4eIMlAf2cJ ogOH8rT9WMt3SD+zCusowQgVpNHFkWbU0ifxJGxFwliRUTz77+3LE8a0o5jR2Rf7zqBQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hXmuc-00053V-1E; Mon, 03 Jun 2019 15:22:06 +0200 Date: Mon, 3 Jun 2019 15:22:06 +0200 From: Andrew Lunn To: Rasmus Villemoes Cc: Vivien Didelot , Florian Fainelli , "David S. Miller" , Rasmus Villemoes , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: fix comments and macro names in mv88e6390_g1_mgmt_rsvd2cpu Message-ID: <20190603132206.GH3154@lunn.ch> References: <20190603075236.18470-1-rasmus.villemoes@prevas.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190603075236.18470-1-rasmus.villemoes@prevas.dk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 03, 2019 at 07:52:46AM +0000, Rasmus Villemoes wrote: > The macros have an extraneous '800' (after 0180C2 there should be just > six nibbles, with X representing one), while the comments have > interchanged c2 and 80 and an extra :00. > > Signed-off-by: Rasmus Villemoes Reviewed-by: Andrew Lunn Andrew