From: Andrew Lunn <andrew@lunn.ch>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc: Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Rasmus Villemoes <Rasmus.Villemoes@prevas.se>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v3 01/10] net: dsa: mv88e6xxx: add mv88e6250_g1_ieee_pri_map
Date: Mon, 3 Jun 2019 16:57:43 +0200 [thread overview]
Message-ID: <20190603145743.GD19627@lunn.ch> (raw)
In-Reply-To: <20190603144112.27713-2-rasmus.villemoes@prevas.dk>
On Mon, Jun 03, 2019 at 02:42:12PM +0000, Rasmus Villemoes wrote:
> diff --git a/drivers/net/dsa/mv88e6xxx/global1.h b/drivers/net/dsa/mv88e6xxx/global1.h
> index bb92a130cbef..2bcbe7c8b279 100644
> --- a/drivers/net/dsa/mv88e6xxx/global1.h
> +++ b/drivers/net/dsa/mv88e6xxx/global1.h
> @@ -279,6 +279,8 @@ int mv88e6390_g1_mgmt_rsvd2cpu(struct mv88e6xxx_chip *chip);
> int mv88e6085_g1_ip_pri_map(struct mv88e6xxx_chip *chip);
> int mv88e6085_g1_ieee_pri_map(struct mv88e6xxx_chip *chip);
>
> +int mv88e6250_g1_ieee_pri_map(struct mv88e6xxx_chip *chip);
> +
Hi Rasmus
We are not 100% consistent, but we try to put all variants of a method
together, and then put a blank line afterwards. So could you make
this:
int mv88e6085_g1_ip_pri_map(struct mv88e6xxx_chip *chip);
int mv88e6085_g1_ieee_pri_map(struct mv88e6xxx_chip *chip);
int mv88e6250_g1_ieee_pri_map(struct mv88e6xxx_chip *chip);
int mv88e6185_g1_set_cascade_port(struct mv88e6xxx_chip *chip, int port);
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-06-03 14:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 14:42 [PATCH net-next v3 00/10] net: dsa: mv88e6xxx: support for mv88e6250 Rasmus Villemoes
2019-06-03 14:42 ` [PATCH net-next v3 01/10] net: dsa: mv88e6xxx: add mv88e6250_g1_ieee_pri_map Rasmus Villemoes
2019-06-03 14:57 ` Andrew Lunn [this message]
2019-06-03 15:37 ` Vivien Didelot
2019-06-03 19:43 ` Rasmus Villemoes
2019-06-03 14:42 ` [PATCH net-next v3 02/10] net: dsa: mv88e6xxx: introduce support for two chips using direct smi addressing Rasmus Villemoes
2019-06-03 14:42 ` [PATCH net-next v3 03/10] net: dsa: mv88e6xxx: prepare mv88e6xxx_g1_atu_op() for the mv88e6250 Rasmus Villemoes
2019-06-03 14:42 ` [PATCH net-next v3 04/10] net: dsa: mv88e6xxx: implement vtu_getnext and vtu_loadpurge for mv88e6250 Rasmus Villemoes
2019-06-03 14:42 ` [PATCH net-next v3 05/10] net: dsa: mv88e6xxx: implement watchdog_ops " Rasmus Villemoes
2019-06-03 14:42 ` [PATCH net-next v3 06/10] net: dsa: mv88e6xxx: implement port_set_speed " Rasmus Villemoes
2019-06-03 15:01 ` Andrew Lunn
2019-06-03 14:42 ` [PATCH net-next v3 07/10] net: dsa: mv88e6xxx: implement port_link_state " Rasmus Villemoes
2019-06-03 15:06 ` Andrew Lunn
2019-06-03 14:42 ` [PATCH net-next v3 08/10] net: dsa: mv88e6xxx: add support " Rasmus Villemoes
2019-06-03 15:16 ` Andrew Lunn
2019-06-03 14:42 ` [PATCH net-next v3 09/10] dt-bindings: net: dsa: marvell: add "marvell,mv88e6250" compatible string Rasmus Villemoes
2019-06-03 15:17 ` Andrew Lunn
2019-06-03 14:42 ` [PATCH net-next v3 10/10] net: dsa: mv88e6xxx: refactor mv88e6352_g1_reset Rasmus Villemoes
2019-06-03 15:18 ` Andrew Lunn
2019-06-03 20:04 ` [PATCH net-next v3 00/10] net: dsa: mv88e6xxx: support for mv88e6250 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603145743.GD19627@lunn.ch \
--to=andrew@lunn.ch \
--cc=Rasmus.Villemoes@prevas.se \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rasmus.villemoes@prevas.dk \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox