Re: [RFC PATCH 22/57] drivers: i2c: Use generic helper to match device by acpi_dev

Suzuki K Poulose
2019-06-10T12:49:30Z

Hi,

On 06/06/2019 21:03, Wolfram Sang wrote:
>
>> - dev = bus_find_device(&i2c_bus_type, NULL, adev,
>> - i2c_acpi_find_match_device);
>> + dev = bus_find_device(&i2c_bus_type, NULL, adev, device_match_acpi_dev);
>
> In general, this looks like a nice cleanup which I am in favour of.
> However, I didn't understand why ACPI uses bus_find_device() but OF has
> a seperate helper bus_find_device_by_of_node(). Why this inconsistency
> of having a seperate helper here and not there?

This was skipped purposefully due to the header file dependency issues with
adding "acpi_bus.h" to linux/device.h, which kind of creates a circular
dependency for adding "struct acpi_device" to the prototype.

However, I think I have found a way to solve that and include that in
the next version.

Thanks
Suzuki