Re: [RFC PATCH 22/57] drivers: i2c: Use generic helper to match device by acpi_dev

Wolfram Sang
2019-06-06T20:03:41Z

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

> - dev = bus_find_device(&i2c_bus_type, NULL, adev,
> - i2c_acpi_find_match_device);
> + dev = bus_find_device(&i2c_bus_type, NULL, adev, device_match_acpi_dev);

In general, this looks like a nice cleanup which I am in favour of.
However, I didn't understand why ACPI uses bus_find_device() but OF has
a seperate helper bus_find_device_by_of_node(). Why this inconsistency
of having a seperate helper here and not there?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]