From: Peter Zijlstra <peterz@infradead.org>
To: "Paul E. McKenney" <paulmck@linux.ibm.com>
Cc: tglx@linutronix.de, mingo@kernel.org, jpoimboe@redhat.com,
mojha@codeaurora.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH HACK RFC] cpu: Prevent late-arriving interrupts from disrupting offline
Date: Tue, 4 Jun 2019 14:06:59 +0200 [thread overview]
Message-ID: <20190604120659.GC3419@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190604081435.GQ28207@linux.ibm.com>
On Tue, Jun 04, 2019 at 01:14:35AM -0700, Paul E. McKenney wrote:
> On Mon, Jun 03, 2019 at 10:38:48AM +0200, Peter Zijlstra wrote:
> > And then there's powerpc which for some obscure reason thinks it needs
> > to enable preemption when dying ?! pseries_cpu_die() actually calls
> > msleep() ?!?!
>
> Isn't pseries_cpu_die() invoked via the smp_ops->cpu_die() function
> pointer, whch is invoked from __cpu_die() in arch/powerpc/kernel/smp.c?
> Then, if I am reading the code correctly, __cpu_die() is invoked from
> takedown_cpu(), which is invoked not from the dying CPU but rather from
> a surviving CPU. Or am I misreading the code?
Argh..
arch_cpu_idle_dead() -> cpu_die() -> ppc_md.cpu_die()
which is _NOT_ smp_ops.cpu_die()
this one ends in pseries_mach_cpu_die()
prev parent reply other threads:[~2019-06-04 12:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 1:12 [PATCH HACK RFC] cpu: Prevent late-arriving interrupts from disrupting offline Paul E. McKenney
2019-06-03 8:38 ` Peter Zijlstra
2019-06-03 11:44 ` Mark Rutland
2019-06-03 13:39 ` Dietmar Eggemann
2019-06-04 7:45 ` Paul E. McKenney
2019-06-04 13:29 ` Dietmar Eggemann
2019-06-08 16:41 ` Paul E. McKenney
2019-06-11 13:14 ` Dietmar Eggemann
2019-06-11 13:54 ` Paul E. McKenney
2019-06-11 14:39 ` Dietmar Eggemann
2019-06-11 19:25 ` Paul E. McKenney
2019-06-04 8:14 ` Paul E. McKenney
2019-06-04 12:06 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604120659.GC3419@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mojha@codeaurora.org \
--cc=paulmck@linux.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox