From: Sam Ravnborg <sam@ravnborg.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
tomi.valkeinen@ti.com, imirkin@alum.mit.edu,
marek.belisko@gmail.com, letux-kernel@openphoenux.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 0/2] drm/panel-simple: Add panel parameters for ortustech-com37h3m05dtc/99dtc and sharp-lq070y3dg3b
Date: Wed, 5 Jun 2019 10:29:42 +0200 [thread overview]
Message-ID: <20190605082942.GC15169@ravnborg.org> (raw)
In-Reply-To: <cover.1559711222.git.hns@goldelico.com>
Hi Nikolaus.
Thanks for the new panel patches.
On Wed, Jun 05, 2019 at 07:07:01AM +0200, H. Nikolaus Schaller wrote:
> V2:
> * fix typo in 99dtc panel compatible string (reported by imirkin@alum.mit.edu)
>
> V1:
>
> Since v5.2-rc1 OMAP is no longer using a special display driver architecture
> for DPI panels, but uses the general drm/panel/panel-simple.
>
> So we finally can add SoC independent panel definitions for two panel models
> which we already had worked on quite a while ago (before device tree was
> introduced):
>
> https://patchwork.kernel.org/patch/2851295/
>
>
>
> H. Nikolaus Schaller (2):
> drm/panel: simple: Add Sharp LQ070Y3DG3B panel support
> drm/panel: simple: Add Ortustech COM37H3M panel support
All three panels are missing binding documentation.
Please submit binding documentation, in separate patches, with
proper "dt-bindings: xxx" subjects.
See Documentation/device-tree/bindings/submitting...
Patches not applied due to the missing docs.
But the patches itself looked good.
You have specified bus_flags etc, and added the
new entries in correct alphabetical order etc.
Sam
next prev parent reply other threads:[~2019-06-05 8:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 5:07 [PATCH v2 0/2] drm/panel-simple: Add panel parameters for ortustech-com37h3m05dtc/99dtc and sharp-lq070y3dg3b H. Nikolaus Schaller
2019-06-05 5:07 ` [PATCH v2 1/2] drm/panel: simple: Add Sharp LQ070Y3DG3B panel support H. Nikolaus Schaller
2019-06-05 5:07 ` [PATCH v2 2/2] drm/panel: simple: Add Ortustech COM37H3M " H. Nikolaus Schaller
2019-06-05 8:29 ` Sam Ravnborg [this message]
2019-06-05 8:31 ` [PATCH v2 0/2] drm/panel-simple: Add panel parameters for ortustech-com37h3m05dtc/99dtc and sharp-lq070y3dg3b H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605082942.GC15169@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=imirkin@alum.mit.edu \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox