From: Jiri Olsa <jolsa@redhat.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v2 4/7] perf diff: Use hists to manage basic blocks per symbol
Date: Wed, 5 Jun 2019 13:44:32 +0200 [thread overview]
Message-ID: <20190605114432.GD5868@krava> (raw)
In-Reply-To: <1559572577-25436-5-git-send-email-yao.jin@linux.intel.com>
On Mon, Jun 03, 2019 at 10:36:14PM +0800, Jin Yao wrote:
SNIP
> sort_compute);
> }
>
> +static int64_t
> +hist_entry__cmp_cycles_idx(struct perf_hpp_fmt *fmt __maybe_unused,
> + struct hist_entry *left __maybe_unused,
> + struct hist_entry *right __maybe_unused)
> +{
> + return 0;
> +}
> +
> static void hists__process(struct hists *hists)
> {
> if (show_baseline_only)
> @@ -746,6 +930,8 @@ static void data_process(void)
> struct perf_evsel *evsel_base;
> bool first = true;
>
> + memset(&dummy_al, 0, sizeof(dummy_al));
why is this needed? it's zero by static declaration, and it's never set, right?
jirka
next prev parent reply other threads:[~2019-06-05 11:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 14:36 [PATCH v2 0/7] perf diff: diff cycles at basic block level Jin Yao
2019-06-03 6:51 ` Jin, Yao
2019-06-03 14:36 ` [PATCH v2 1/7] perf util: Create block_info structure Jin Yao
2019-06-03 14:36 ` [PATCH v2 2/7] perf util: Add block_info in hist_entry Jin Yao
2019-06-03 14:36 ` [PATCH v2 3/7] perf diff: Check if all data files with branch stacks Jin Yao
2019-06-03 14:36 ` [PATCH v2 4/7] perf diff: Use hists to manage basic blocks per symbol Jin Yao
2019-06-05 11:44 ` Jiri Olsa
2019-06-06 1:15 ` Jin, Yao
2019-06-08 11:41 ` Jin, Yao
2019-06-11 2:22 ` Jin, Yao
2019-06-11 8:56 ` Jiri Olsa
2019-06-12 6:11 ` Jin, Yao
2019-06-12 7:44 ` Jiri Olsa
2019-06-12 12:54 ` Jin, Yao
2019-06-05 11:44 ` Jiri Olsa [this message]
2019-06-06 1:26 ` Jin, Yao
2019-06-05 11:44 ` Jiri Olsa
2019-06-06 1:57 ` Jin, Yao
2019-06-03 14:36 ` [PATCH v2 5/7] perf diff: Link same basic blocks among different data files Jin Yao
2019-06-03 14:36 ` [PATCH v2 6/7] perf diff: Print the basic block cycles diff Jin Yao
2019-06-05 11:44 ` Jiri Olsa
2019-06-06 4:06 ` Jin, Yao
2019-06-05 11:44 ` Jiri Olsa
2019-06-06 2:02 ` Jin, Yao
2019-06-03 14:36 ` [PATCH v2 7/7] perf diff: Documentation -c cycles option Jin Yao
2019-06-05 11:44 ` [PATCH v2 0/7] perf diff: diff cycles at basic block level Jiri Olsa
2019-06-06 1:05 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605114432.GD5868@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox