From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B95DFC28CC5 for ; Wed, 5 Jun 2019 11:44:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93B64206DF for ; Wed, 5 Jun 2019 11:44:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728028AbfFELoq (ORCPT ); Wed, 5 Jun 2019 07:44:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36188 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727535AbfFELop (ORCPT ); Wed, 5 Jun 2019 07:44:45 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 204017E437; Wed, 5 Jun 2019 11:44:37 +0000 (UTC) Received: from krava (unknown [10.43.17.136]) by smtp.corp.redhat.com (Postfix) with SMTP id 33B231001E73; Wed, 5 Jun 2019 11:44:33 +0000 (UTC) Date: Wed, 5 Jun 2019 13:44:32 +0200 From: Jiri Olsa To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v2 4/7] perf diff: Use hists to manage basic blocks per symbol Message-ID: <20190605114432.GD5868@krava> References: <1559572577-25436-1-git-send-email-yao.jin@linux.intel.com> <1559572577-25436-5-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1559572577-25436-5-git-send-email-yao.jin@linux.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 05 Jun 2019 11:44:45 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 03, 2019 at 10:36:14PM +0800, Jin Yao wrote: SNIP > sort_compute); > } > > +static int64_t > +hist_entry__cmp_cycles_idx(struct perf_hpp_fmt *fmt __maybe_unused, > + struct hist_entry *left __maybe_unused, > + struct hist_entry *right __maybe_unused) > +{ > + return 0; > +} > + > static void hists__process(struct hists *hists) > { > if (show_baseline_only) > @@ -746,6 +930,8 @@ static void data_process(void) > struct perf_evsel *evsel_base; > bool first = true; > > + memset(&dummy_al, 0, sizeof(dummy_al)); why is this needed? it's zero by static declaration, and it's never set, right? jirka