Re: [tip:locking/core] Documentation/atomic_t.txt: Clarify pure non-rmw usage

Andrea Parri
2019-06-06T09:11:47Z

On Thu, Jun 06, 2019 at 11:04:39AM +0200, Peter Zijlstra wrote:
> On Thu, Jun 06, 2019 at 10:44:21AM +0200, Andrea Parri wrote:
> > On Mon, Jun 03, 2019 at 06:46:54AM -0700, tip-bot for Peter Zijlstra wrote:
> > > Commit-ID: fff9b6c7d26943a8eb32b58364b7ec6b9369746a
> > > Gitweb: https://git.kernel.org/tip/fff9b6c7d26943a8eb32b58364b7ec6b9369746a
> > > Author: Peter Zijlstra <peterz@infradead.org>
> > > AuthorDate: Fri, 24 May 2019 13:52:31 +0200
> > > Committer: Ingo Molnar <mingo@kernel.org>
> > > CommitDate: Mon, 3 Jun 2019 12:32:57 +0200
> > >
> > > Documentation/atomic_t.txt: Clarify pure non-rmw usage
> > >
> > > Clarify that pure non-RMW usage of atomic_t is pointless, there is
> > > nothing 'magical' about atomic_set() / atomic_read().
> > >
> > > This is something that seems to confuse people, because I happen upon it
> > > semi-regularly.
> > >
> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Acked-by: Will Deacon <will.deacon@arm.com>
> > > Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > > Cc: Peter Zijlstra <peterz@infradead.org>
> > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > Link: https://lkml.kernel.org/r/20190524115231.GN2623@hirez.programming.kicks-ass.net
> > > Signed-off-by: Ingo Molnar <mingo@kernel.org>
> >
> > I'd appreciate if you could Cc: me in future changes to this doc.
> > (as currently suggested by get_maintainer.pl).
> >
> > This is particularly annoying when you spend time to review such
> > changes:
> >
> > https://lkml.kernel.org/r/20190528111558.GA9106@andrea
>
> Sure, I hadn't realized the LKMM entry had appropriated this file, I
> considered it part of the ATOMIC entry there.

Thanks. Well, that was not a 'secret', c.f.,

70b83069f70d ("tools/memory-model: Add informal LKMM documentation to MAINTAINERS")

Andrea