From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3FDBC04AB5 for ; Thu, 6 Jun 2019 12:59:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E34B20868 for ; Thu, 6 Jun 2019 12:59:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559825970; bh=7RZShAsT5Ac6fwFUJ8T+626Y3eZ1PxJCUZdWLG205eg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=X83Ot6YnP28MamZPQvZB5J5i5OIZ97MmU3g2MDbYvkObspvI9xAx+8hSshaHNXy6j w8G5+JTSKOP/PdIUgQCo8nO6tqmyK8Dfyx4dgyB5UGX0zTssSfL2V7W4wSC/yhpZiZ uUm/yMHlcWPNNCPoC6leERx3cKWIuSv+iEfDGwlA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728138AbfFFM73 (ORCPT ); Thu, 6 Jun 2019 08:59:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:37242 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726693AbfFFM73 (ORCPT ); Thu, 6 Jun 2019 08:59:29 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4FE302070B; Thu, 6 Jun 2019 12:59:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559825968; bh=7RZShAsT5Ac6fwFUJ8T+626Y3eZ1PxJCUZdWLG205eg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wRh86ID9iECC18xel4NOQx4MuIWjxcTY7A/Cq7ChoLU+9djPc4mzch9FO8j9RzVoe YB2TtTqNJ86cfLEj3lXYWFy4KcmIKHe0HJ/VoyoDmU56sSSfr9QvhfSxY0MlluXH8T +rqSl8MdcxtcRlKLZ16dMMjN0BWHvYV+uXUpkF1A= Date: Thu, 6 Jun 2019 14:59:26 +0200 From: Greg KH To: Nishka Dasgupta Cc: larry.finger@lwfinger.net, straube.linux@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, flbue@gmx.de, puranjay12@gmail.com Subject: Re: [PATCH] staging: rtl8188eu: core: Replace function rtw_free_network_nolock Message-ID: <20190606125926.GA1140@kroah.com> References: <20190604081222.12658-1-nishkadg.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190604081222.12658-1-nishkadg.linux@gmail.com> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 04, 2019 at 01:42:22PM +0530, Nishka Dasgupta wrote: > Remove function rtw_free_network_nolock, as all it does is call > _rtw_free_network_nolock, and rename _rtw_free_network_nolock to > rtw_free_network_nolock. > > Signed-off-by: Nishka Dasgupta > --- > drivers/staging/rtl8188eu/core/rtw_mlme.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c > index 0abb2df32645..454c5795903d 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_mlme.c > +++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c > @@ -159,7 +159,7 @@ static void _rtw_free_network(struct mlme_priv *pmlmepriv, struct wlan_network * > spin_unlock_bh(&free_queue->lock); > } > > -void _rtw_free_network_nolock(struct mlme_priv *pmlmepriv, struct wlan_network *pnetwork) > +void rtw_free_network_nolock(struct mlme_priv *pmlmepriv, struct wlan_network *pnetwork) Why is this function moved from being static to not being static? that doesn't seem right to me, does it to you? thanks, greg k-h