From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D78ABC04AB5 for ; Thu, 6 Jun 2019 16:02:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93ED1206DF for ; Thu, 6 Jun 2019 16:02:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559836952; bh=96z3Elkgrr+iSpmAnXe8RdLlNb1tSjIsOLLmdBj8Z8g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=TW4VEIWSqFJ2YrQXbdE2Nx/jdfbJCApdWILX0nu+6oKomfJmxHfy5a3KPNRpnDEQj xetxUrjeafP5j4u2p2MMD8R9h/FZF6zV1ombExIsX9raACO0AIvPF/5UM0zsnjRQqV 1ec6m5nLFpq2+c5CjzbUwSX0t8zTgewlGZmnENiY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729550AbfFFQCb (ORCPT ); Thu, 6 Jun 2019 12:02:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:37274 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729162AbfFFQCb (ORCPT ); Thu, 6 Jun 2019 12:02:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 32DA720645; Thu, 6 Jun 2019 16:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559836950; bh=96z3Elkgrr+iSpmAnXe8RdLlNb1tSjIsOLLmdBj8Z8g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SjuPU/k9hlIieLjbhCrciuv1C2v4bTuYxfFHTgTVjTN/HcPgmevO3W8dKFtiz895Y +6WOmBQ9+zYb7AHsiRCpsnIBJmwyi6f+gW0abbba+WzaM8ithw1ms9P7hVjnNQsqDs 5H4BBMec17s0kaAAWEULK9dmDepPOZBPoAkDDBQs= Date: Thu, 6 Jun 2019 18:02:28 +0200 From: Greg Kroah-Hartman To: Peter Zijlstra Cc: Andrea Parri , linux-kernel@vger.kernel.org, will.deacon@arm.com, arnd@arndb.de, jhansen@vmware.com, vdasa@vmware.com, aditr@vmware.com, Steven Rostedt Subject: Re: [PATCH] VMCI: Fixup atomic64_t abuse Message-ID: <20190606160228.GA29583@kroah.com> References: <20190606093428.GF3402@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190606093428.GF3402@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 06, 2019 at 11:34:28AM +0200, Peter Zijlstra wrote: > > The VMCI driver is abusing atomic64_t and atomic_t, there is no actual > atomic RmW operations around. > > Rewrite the code to use a regular u64 with READ_ONCE() and > WRITE_ONCE() and a cast to 'unsigned long'. This fully preserves > whatever broken there was (it's not endian-safe for starters, and also > looks to be missing ordering). > > Signed-off-by: Peter Zijlstra (Intel) > --- > include/linux/vmw_vmci_defs.h | 30 ++++++++++-------------------- > 1 file changed, 10 insertions(+), 20 deletions(-) Now applied. It's pretty horrid code, at least it's a tiny bit better now... thanks, greg k-h