From: Stephen Boyd <sboyd@kernel.org>
To: Philippe Mazenauer <philippe.mazenauer@outlook.de>
Cc: Philippe Mazenauer <philippe.mazenauer@outlook.de>,
Michael Turquette <mturquette@baylibre.com>,
Gregory CLEMENT <gregory.clement@bootlin.com>,
Yangtao Li <tiny.windzz@gmail.com>,
"open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: armada-xp: Remove unused variables
Date: Thu, 06 Jun 2019 11:07:07 -0700 [thread overview]
Message-ID: <20190606180708.0BD302089E@mail.kernel.org> (raw)
In-Reply-To: <VI1PR07MB4432F4F275BC445289FF3D9CFD070@VI1PR07MB4432.eurprd07.prod.outlook.com>
Quoting Philippe Mazenauer (2019-05-21 01:58:41)
> Variables 'mv98dx3236_gating_desc' and 'mv98dx3236_coreclks' are
> declared static and initialized, but are not used in the file.
>
> ../drivers/clk/mvebu/armada-xp.c:213:41: warning: ‘mv98dx3236_gating_desc’ defined but not used [-Wunused-const-variable=]
> static const struct clk_gating_soc_desc mv98dx3236_gating_desc[] __initconst = {
> ^~~~~~~~~~~~~~~~~~~~~~
> ../drivers/clk/mvebu/armada-xp.c:171:38: warning: ‘mv98dx3236_coreclks’ defined but not used [-Wunused-const-variable=]
> static const struct coreclk_soc_desc mv98dx3236_coreclks = {
> ^~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
> ---
> drivers/clk/mvebu/armada-xp.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/clk/mvebu/armada-xp.c b/drivers/clk/mvebu/armada-xp.c
> index fa1568279c23..2ae24a5debd0 100644
> --- a/drivers/clk/mvebu/armada-xp.c
> +++ b/drivers/clk/mvebu/armada-xp.c
> @@ -168,11 +168,6 @@ static const struct coreclk_soc_desc axp_coreclks = {
> .num_ratios = ARRAY_SIZE(axp_coreclk_ratios),
> };
>
> -static const struct coreclk_soc_desc mv98dx3236_coreclks = {
> - .get_tclk_freq = mv98dx3236_get_tclk_freq,
> - .get_cpu_freq = mv98dx3236_get_cpu_freq,
These functions are unused after applying this patch. Can you resend by
test compiling the code?
prev parent reply other threads:[~2019-06-06 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 8:58 [PATCH] clk: armada-xp: Remove unused variables Philippe Mazenauer
2019-05-21 21:31 ` Chris Packham
2019-06-06 17:48 ` Stephen Boyd
2019-06-06 18:07 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606180708.0BD302089E@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=philippe.mazenauer@outlook.de \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox