Re: [PATCH V3 1/5] perf cpumap: Retrieve die id information

Jiri Olsa
2019-06-05T09:09:11Z

On Tue, Jun 04, 2019 at 03:50:40PM -0700, kan.liang@linux.intel.com wrote:
> From: Kan Liang <kan.liang@linux.intel.com>
>
> There is no function to retrieve die id information of a given CPU.
>
> Add cpu_map__get_die_id() to retrieve die id information.
>
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> ---
>
> No changes since V2.

Reviewed-by: Jiri Olsa <jolsa@kernel.org>

for the whole patchset

thanks,
jirka

>
> tools/perf/util/cpumap.c | 7 +++++++
> tools/perf/util/cpumap.h | 1 +
> 2 files changed, 8 insertions(+)
>
> diff --git a/tools/perf/util/cpumap.c b/tools/perf/util/cpumap.c
> index 0b59922..7db1365 100644
> --- a/tools/perf/util/cpumap.c
> +++ b/tools/perf/util/cpumap.c
> @@ -373,6 +373,13 @@ int cpu_map__build_map(struct cpu_map *cpus, struct cpu_map **res,
> return 0;
> }
>
> +int cpu_map__get_die_id(int cpu)
> +{
> + int value, ret = cpu__get_topology_int(cpu, "die_id", &value);
> +
> + return ret ?: value;
> +}
> +
> int cpu_map__get_core_id(int cpu)
> {
> int value, ret = cpu__get_topology_int(cpu, "core_id", &value);
> diff --git a/tools/perf/util/cpumap.h b/tools/perf/util/cpumap.h
> index f00ce62..6762ff9 100644
> --- a/tools/perf/util/cpumap.h
> +++ b/tools/perf/util/cpumap.h
> @@ -25,6 +25,7 @@ size_t cpu_map__snprint_mask(struct cpu_map *map, char *buf, size_t size);
> size_t cpu_map__fprintf(struct cpu_map *map, FILE *fp);
> int cpu_map__get_socket_id(int cpu);
> int cpu_map__get_socket(struct cpu_map *map, int idx, void *data);
> +int cpu_map__get_die_id(int cpu);
> int cpu_map__get_core_id(int cpu);
> int cpu_map__get_core(struct cpu_map *map, int idx, void *data);
> int cpu_map__build_socket_map(struct cpu_map *cpus, struct cpu_map **sockp);
> --
> 2.7.4
>