From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25129C28CC3 for ; Fri, 7 Jun 2019 06:04:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA5702089E for ; Fri, 7 Jun 2019 06:04:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726840AbfFGGEC (ORCPT ); Fri, 7 Jun 2019 02:04:02 -0400 Received: from sauhun.de ([88.99.104.3]:40708 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726575AbfFGGEB (ORCPT ); Fri, 7 Jun 2019 02:04:01 -0400 Received: from localhost (p5486CE26.dip0.t-ipconnect.de [84.134.206.38]) by pokefinder.org (Postfix) with ESMTPSA id 589BC3E43BA; Fri, 7 Jun 2019 08:03:59 +0200 (CEST) Date: Fri, 7 Jun 2019 08:03:59 +0200 From: Wolfram Sang To: Bitan Biswas Cc: Laxman Dewangan , Thierry Reding , Jonathan Hunter , linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Shardar Mohammed , Sowjanya Komatineni , Mantravadi Karthik Subject: Re: [PATCH V5] drivers: i2c: tegra: fix warning/check/error Message-ID: <20190607060358.GB1035@kunai> References: <1559885103-9113-1-git-send-email-bbiswas@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p4qYPpj5QlsIQJ0K" Content-Disposition: inline In-Reply-To: <1559885103-9113-1-git-send-email-bbiswas@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --p4qYPpj5QlsIQJ0K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 06, 2019 at 10:25:03PM -0700, Bitan Biswas wrote: > Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c >=20 > Ignore checkpatch WARNING for 80 character line limit at > places where renaming fields compromises readability. >=20 > Delay of approximately 1msec in flush i2c FIFO polling loop > achieved by usleep_range call as msleep can take 20msecs. >=20 > Remove redundant BUG_ON calls or replace with WARN_ON_ONCE > as needed. Replace BUG() with error handling code. > Define I2C_ERR_UNEXPECTED_STATUS for error handling. You removed the word checkpatch from $subject, but you still did not split up the patch into logical pieces. The description above already outlines what those logical pieces could be. --p4qYPpj5QlsIQJ0K Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlz5/k4ACgkQFA3kzBSg KbbgTRAAnTLiDO728xUWu9TRt7xV7nL0szeMhE4O71rzXpd+Ru7m5yEta8k1HaCz WOisQkIuNFJaCQC5eeeJK5HTSshuHLtHiYvDLWbsbl9YUmdzK9JQtFTJavlxJFUB 6ZryrBPXQufTRKRtbYf1I3Hh7Ow+tVjq5pfFrdrF7OttryTe8h40SYqxtRhj78mk WkXte7hvVach56fYLQldRqHMGacnGOoePC9P9Uoh5X+kvHdxrOI7NScH2HWFcCtE UC6NnEtm3ZdlYFrvww/iKlZmj6f7tDww3TpEoMDJQ8mPfZu1AWQdCJ4Dyezf2SgB j1lJQDO4JCVnpxhfWnvWfanAuqCM3SmUonXk2kcaNeaF3T4Wtv/Z5XoR+wXOg3qL 64drNdEulCk7aPzW63zQGlOessCJKUz1I7LDnzKOqKVzkPqNmhlk7nLKTxvZ5UkQ /kOpKiyt5cgwYHfvfGHxWjbSh9F0IouCYUi/OymMQX7KCX1pb8sXDh6QqpO84Yiy 2IihYu0swkdjpxAQgvnzy0UhWpJnzjyjxBkriiuUUkUYhUWeoWDMkLsQXJUAX4nB ArQa/KHCA9WxQ2cMiBideFTYvhvoaKq83+qhySzdyUbXjbuJXpXG8DtBNZm+dP44 yaGPrJpXdeMq41zJ+CGjagdK+n0wu3xih6jmgBy+Hq1aZXqr8lo= =6AkS -----END PGP SIGNATURE----- --p4qYPpj5QlsIQJ0K--