From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: nVMX: Rename prepare_vmcs02_*_full to prepare_vmcs02_*_extra
Date: Fri, 7 Jun 2019 09:04:22 -0700 [thread overview]
Message-ID: <20190607160422.GE9083@linux.intel.com> (raw)
In-Reply-To: <5762005d-1504-bb41-9583-ec549e107ce5@redhat.com>
On Fri, Jun 07, 2019 at 05:17:09PM +0200, Paolo Bonzini wrote:
> On 07/06/19 16:18, Sean Christopherson wrote:
> > On Fri, Jun 07, 2019 at 02:19:20PM +0200, Paolo Bonzini wrote:
> >> On 06/06/19 20:41, Sean Christopherson wrote:
> >>>> +static void prepare_vmcs02_early_extra(struct vcpu_vmx *vmx,
> >>> Or maybe 'uncommon', 'rare' or 'ext'? I don't I particularly love any of
> >>> the names, but they're all better than 'full'.
> >>
> >> I thought 'ext' was short for 'extra'? :)
> >
> > Ha, I (obviously) didn't make that connection. ext == extended in my mind.
>
> That's what came to mind first, but then "extended" had the same issue
> as "full" (i.e. encompassing the "basic" set as well) so I decided you
> knew better!
Ah, I was thinking of "basic" and "extended" as separate states, but your
interpretation is correct.
I probably have a slight preference for 'uncommon' over 'extra'? I feel
like they have equal odds of being misinterpreted, so pick your poison :-)
next prev parent reply other threads:[~2019-06-07 16:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 15:24 [PATCH] KVM: nVMX: Rename prepare_vmcs02_*_full to prepare_vmcs02_*_extra Paolo Bonzini
2019-06-06 18:41 ` Sean Christopherson
2019-06-06 19:19 ` Krish Sadhukhan
2019-06-06 20:19 ` Paolo Bonzini
2019-06-07 12:19 ` Paolo Bonzini
2019-06-07 14:18 ` Sean Christopherson
2019-06-07 15:17 ` Paolo Bonzini
2019-06-07 16:04 ` Sean Christopherson [this message]
2019-06-07 16:24 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607160422.GE9083@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox