From: Jean Delvare <jdelvare@suse.de>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: "Wolfram Sang" <wsa@the-dreams.de>,
"Michał Kępień" <kernel@kempniu.pl>,
"Steven Honeyman" <stevenhoneyman@gmail.com>,
Valdis.Kletnieks@vt.edu,
"Jochen Eisinger" <jochen@penguin-breeder.org>,
"Gabriele Mazzotta" <gabriele.mzt@gmail.com>,
"Andy Lutomirski" <luto@kernel.org>,
Mario_Limonciello@dell.com, "Alex Hung" <alex.hung@canonical.com>,
"Takashi Iwai" <tiwai@suse.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v5] i2c: i801: Register optional lis3lv02d I2C device on Dell machines
Date: Fri, 7 Jun 2019 16:16:40 +0200 [thread overview]
Message-ID: <20190607161640.0d90e1b9@endymion> (raw)
In-Reply-To: <20190606181845.14091-1-pali.rohar@gmail.com>
On Thu, 6 Jun 2019 20:18:45 +0200, Pali Rohár wrote:
> Dell platform team told us that some (DMI whitelisted) Dell Latitude
> machines have ST microelectronics accelerometer at I2C address 0x29.
>
> Presence of that ST microelectronics accelerometer is verified by existence
> of SMO88xx ACPI device which represent that accelerometer. Unfortunately
> ACPI device does not specify I2C address.
>
> This patch registers lis3lv02d device for selected Dell Latitude machines
> at I2C address 0x29 after detection. And for Dell Vostro V131 machine at
> I2C address 0x1d which was manually detected.
>
> Finally commit a7ae81952cda ("i2c: i801: Allow ACPI SystemIO OpRegion to
> conflict with PCI BAR") allowed to use i2c-i801 driver on Dell machines so
> lis3lv02d correctly initialize accelerometer.
>
> Tested on Dell Latitude E6440.
>
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
>
> ---
> Changes since v4:
> * Remove usage of redundant acpi_bus_get_status_handle()
> * Update comment about acpi_get_devices()
> (...)
Looks all good now.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Thanks!
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2019-06-07 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 18:18 [PATCH v5] i2c: i801: Register optional lis3lv02d I2C device on Dell machines Pali Rohár
2019-06-07 14:16 ` Jean Delvare [this message]
2019-06-07 22:15 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607161640.0d90e1b9@endymion \
--to=jdelvare@suse.de \
--cc=Mario_Limonciello@dell.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=alex.hung@canonical.com \
--cc=gabriele.mzt@gmail.com \
--cc=jochen@penguin-breeder.org \
--cc=kernel@kempniu.pl \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stevenhoneyman@gmail.com \
--cc=tiwai@suse.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox