From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9C49C28CC5 for ; Sat, 8 Jun 2019 11:46:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93313214AF for ; Sat, 8 Jun 2019 11:46:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559994379; bh=9o30CDTGUyQ6F1IMu35gTWuAxwpRxBPb0ADbXdLDhuo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=AlE/3PiKp2OGQNzQY9SYLPyPAThJylKSWOxHP3WzpEMG+KQO/dxCmcovlFmo0R9X0 UrQqaR7Kam49ib2YHFsYfxuu7VKT6WTLpc2G5Oxou/jP/39ZizvEJncP43ONcuzAFF VYDtMET2uD3OD8P3ahj4VcTtk/Cx47g5vsLI35RA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728427AbfFHLmY (ORCPT ); Sat, 8 Jun 2019 07:42:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:59610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728381AbfFHLmS (ORCPT ); Sat, 8 Jun 2019 07:42:18 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 76834214AF; Sat, 8 Jun 2019 11:42:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559994138; bh=9o30CDTGUyQ6F1IMu35gTWuAxwpRxBPb0ADbXdLDhuo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kU6EQbS0TzeCoCn2lXQb7GYr4u0B9HuKPWMzlTmz5pQZD1uZ+rAdYyF6xGhAhbKGm JhfcPx5xOVxFAQyaJE1V4fR7EBMf0Nw4K11aBy+npMFktFAR2UD+8PKLOhAdAO2LsH M/cLWZvBu+7tWEYxUbeJB6+NNJSjr6QhCfKk1ePk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Varun Prakash , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.1 65/70] scsi: libcxgbi: add a check for NULL pointer in cxgbi_check_route() Date: Sat, 8 Jun 2019 07:39:44 -0400 Message-Id: <20190608113950.8033-65-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190608113950.8033-1-sashal@kernel.org> References: <20190608113950.8033-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Varun Prakash [ Upstream commit cc555759117e8349088e0c5d19f2f2a500bafdbd ] ip_dev_find() can return NULL so add a check for NULL pointer. Signed-off-by: Varun Prakash Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/cxgbi/libcxgbi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c index 006372b3fba2..a50734f3c486 100644 --- a/drivers/scsi/cxgbi/libcxgbi.c +++ b/drivers/scsi/cxgbi/libcxgbi.c @@ -641,6 +641,10 @@ cxgbi_check_route(struct sockaddr *dst_addr, int ifindex) if (ndev->flags & IFF_LOOPBACK) { ndev = ip_dev_find(&init_net, daddr->sin_addr.s_addr); + if (!ndev) { + err = -ENETUNREACH; + goto rel_neigh; + } mtu = ndev->mtu; pr_info("rt dev %s, loopback -> %s, mtu %u.\n", n->dev->name, ndev->name, mtu); -- 2.20.1