public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] blk-mq: fix coding style
@ 2019-06-08 13:47 Soonwoo Hong
  2019-06-08 15:54 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Soonwoo Hong @ 2019-06-08 13:47 UTC (permalink / raw)
  To: gregkh; +Cc: linux-kernel, Soonwoo Hong

Add a space before colon in ternary operator

Singed-off-by: Soonwoo Hong <qpseh2m7@gmail.com>
---
 block/blk-mq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index ce0f5f4ede70..374b13e89bb1 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1377,7 +1377,7 @@ static void __blk_mq_run_hw_queue(struct blk_mq_hw_ctx *hctx)
 		cpu_online(hctx->next_cpu)) {
 		printk(KERN_WARNING "run queue from wrong CPU %d, hctx %s\n",
 			raw_smp_processor_id(),
-			cpumask_empty(hctx->cpumask) ? "inactive": "active");
+			cpumask_empty(hctx->cpumask) ? "inactive" : "active");
 		dump_stack();
 	}
 
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] blk-mq: fix coding style
  2019-06-08 13:47 [PATCH] blk-mq: fix coding style Soonwoo Hong
@ 2019-06-08 15:54 ` Greg KH
  2019-06-08 15:55   ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2019-06-08 15:54 UTC (permalink / raw)
  To: Soonwoo Hong; +Cc: linux-kernel

On Sat, Jun 08, 2019 at 10:47:28PM +0900, Soonwoo Hong wrote:
> Add a space before colon in ternary operator
> 
> Singed-off-by: Soonwoo Hong <qpseh2m7@gmail.com>
> ---
>  block/blk-mq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

$ ./scripts/get_maintainer.pl --file block/blk-mq.c
Jens Axboe <axboe@kernel.dk> (maintainer:BLOCK LAYER)
linux-block@vger.kernel.org (open list:BLOCK LAYER)
linux-kernel@vger.kernel.org (open list)


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] blk-mq: fix coding style
  2019-06-08 15:54 ` Greg KH
@ 2019-06-08 15:55   ` Greg KH
  0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-06-08 15:55 UTC (permalink / raw)
  To: Soonwoo Hong; +Cc: linux-kernel

On Sat, Jun 08, 2019 at 05:54:46PM +0200, Greg KH wrote:
> On Sat, Jun 08, 2019 at 10:47:28PM +0900, Soonwoo Hong wrote:
> > Add a space before colon in ternary operator
> > 
> > Singed-off-by: Soonwoo Hong <qpseh2m7@gmail.com>
> > ---
> >  block/blk-mq.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> $ ./scripts/get_maintainer.pl --file block/blk-mq.c
> Jens Axboe <axboe@kernel.dk> (maintainer:BLOCK LAYER)
> linux-block@vger.kernel.org (open list:BLOCK LAYER)
> linux-kernel@vger.kernel.org (open list)
> 

Also, doing coding style cleanups outside of drivers/staging/ is a tough
thing to do, please don't make it harder on yourself...

good luck!

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-06-08 15:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-08 13:47 [PATCH] blk-mq: fix coding style Soonwoo Hong
2019-06-08 15:54 ` Greg KH
2019-06-08 15:55   ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox