From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3EEDC28EBD for ; Sun, 9 Jun 2019 11:05:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B31D62083D for ; Sun, 9 Jun 2019 11:05:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728422AbfFILFX (ORCPT ); Sun, 9 Jun 2019 07:05:23 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:54485 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728095AbfFILFX (ORCPT ); Sun, 9 Jun 2019 07:05:23 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 362B4802CC; Sun, 9 Jun 2019 13:05:10 +0200 (CEST) Date: Sun, 9 Jun 2019 13:05:20 +0200 From: Pavel Machek To: Jacek Anaszewski Cc: Wolfram Sang , linux-i2c@vger.kernel.org, Dan Murphy , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/34] leds: leds-pca955x: simplify getting the adapter of a client Message-ID: <20190609110519.GA2375@amd> References: <20190608105619.593-1-wsa+renesas@sang-engineering.com> <20190608105619.593-5-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AqsLC8rIMeq19msA" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --AqsLC8rIMeq19msA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun 2019-06-09 13:03:40, Jacek Anaszewski wrote: > Hi Wolfram, >=20 > Thank you for the patches. >=20 > On 6/8/19 12:55 PM, Wolfram Sang wrote: > >We have a dedicated pointer for that, so use it. Much easier to read and > >less computation involved. > > > >Signed-off-by: Wolfram Sang > >--- > > > >Please apply to your subsystem tree. > > > > drivers/leds/leds-pca955x.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c > >index a9f5dad55956..460626d81c6a 100644 > >--- a/drivers/leds/leds-pca955x.c > >+++ b/drivers/leds/leds-pca955x.c > >@@ -432,7 +432,7 @@ static int pca955x_probe(struct i2c_client *client, > > int ngpios =3D 0; > > chip =3D &pca955x_chipdefs[id->driver_data]; > >- adapter =3D to_i2c_adapter(client->dev.parent); > >+ adapter =3D client->adapter; > > pdata =3D dev_get_platdata(&client->dev); > > if (!pdata) { > > pdata =3D pca955x_get_pdata(client, chip); > > >=20 > For both 4/34 and 5/34: >=20 > Acked-by: Jacek Anaszewski 4 and 5: Acked-by: Pavel Machek But I wonder if it should go through the leds tree? Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --AqsLC8rIMeq19msA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlz85+8ACgkQMOfwapXb+vK6YQCfbTAciJbPFiikZaSzNawQ4CTP iXgAn15Z789Y3jOmbvgrZWlNJ11pvPAE =V47/ -----END PGP SIGNATURE----- --AqsLC8rIMeq19msA--